qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] timespec convert funcs: return a value in the normal case
@ 2008-05-10 13:13 Mike Frysinger
  0 siblings, 0 replies; only message in thread
From: Mike Frysinger @ 2008-05-10 13:13 UTC (permalink / raw)
  To: qemu-devel

The target_to_host_timespec and host_to_target_timespec funcs lack a
"return" at the end of the functions which means random values may get
passed back in the successful case.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 linux-user/syscall.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 0e506cc..5b88e62 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -3040,6 +3040,7 @@ static inline abi_long target_to_host_timespec(struct timespec *host_ts,
     host_ts->tv_sec = tswapl(target_ts->tv_sec);
     host_ts->tv_nsec = tswapl(target_ts->tv_nsec);
     unlock_user_struct(target_ts, target_addr, 0);
+    return 0;
 }
 
 static inline abi_long host_to_target_timespec(abi_ulong target_addr,
@@ -3052,6 +3053,7 @@ static inline abi_long host_to_target_timespec(abi_ulong target_addr,
     target_ts->tv_sec = tswapl(host_ts->tv_sec);
     target_ts->tv_nsec = tswapl(host_ts->tv_nsec);
     unlock_user_struct(target_ts, target_addr, 1);
+    return 0;
 }
 
 int get_osversion(void)
-- 
1.5.5.1

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2008-05-10 13:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-10 13:13 [Qemu-devel] [PATCH] timespec convert funcs: return a value in the normal case Mike Frysinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).