From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JweBC-00066F-JW for qemu-devel@nongnu.org; Thu, 15 May 2008 10:11:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JweBA-00064Z-IT for qemu-devel@nongnu.org; Thu, 15 May 2008 10:11:33 -0400 Received: from [199.232.76.173] (port=47129 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JweB9-000644-VN for qemu-devel@nongnu.org; Thu, 15 May 2008 10:11:32 -0400 Received: from mail.windriver.com ([147.11.1.11]:50479 helo=mail.wrs.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JweB9-0003TQ-1W for qemu-devel@nongnu.org; Thu, 15 May 2008 10:11:31 -0400 Received: from ALA-MAIL03.corp.ad.wrs.com (ala-mail03 [147.11.57.144]) by mail.wrs.com (8.13.6/8.13.6) with ESMTP id m4FEBTg6000016 for ; Thu, 15 May 2008 07:11:29 -0700 (PDT) From: Jason Wessel Date: Thu, 15 May 2008 09:11:33 -0500 Message-Id: <1210860693-22245-6-git-send-email-jason.wessel@windriver.com> In-Reply-To: <1210860693-22245-5-git-send-email-jason.wessel@windriver.com> References: <1210860693-22245-1-git-send-email-jason.wessel@windriver.com> <1210860693-22245-2-git-send-email-jason.wessel@windriver.com> <1210860693-22245-3-git-send-email-jason.wessel@windriver.com> <1210860693-22245-4-git-send-email-jason.wessel@windriver.com> <1210860693-22245-5-git-send-email-jason.wessel@windriver.com> Subject: [Qemu-devel] [PATCH 5/5] ppc: fix crash in ppc system single step support Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org There was a bogus case where two system debug ops get generated. This patch removes the broken system debug op. This was a left over after making some changes to correctly generate debug ops on branch operations inside gen_goto_tb(); The test case against this patch is to turn on single stepping with timers, boot a linux kernel, set a breakpoint a do_fork and in gdb execute "si 3000". Then qemu-system-ppc will fault executing a debug op, which should not have been executed. Signed-off-by: Jason Wessel --- target-ppc/translate.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 4e71614..45da869 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -3002,10 +3002,6 @@ static always_inline void gen_bcond (DisasContext *ctx, int type) #endif gen_op_btest_T1(ctx->nip); no_test: - if (ctx->singlestep_enabled & GDBSTUB_SINGLE_STEP) { - gen_update_nip(ctx, ctx->nip); - gen_op_debug(); - } tcg_gen_exit_tb(0); } } -- 1.5.5.1