From: Amit Shah <amit.shah@qumranet.com>
To: qemu-devel@nongnu.org
Cc: Amit Shah <amit.shah@qumranet.com>, kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH 10/14] QEMU: Fill in PCI subsystem vendor id for rtl8139
Date: Mon, 26 May 2008 13:36:49 +0300 [thread overview]
Message-ID: <1211798213-4187-13-git-send-email-amit.shah@qumranet.com> (raw)
In-Reply-To: <1211798213-4187-12-git-send-email-amit.shah@qumranet.com>
The subsystem vendor ID shouldn't be 0x0 or 0xffff according
to the PCI spec
Signed-off-by: Amit Shah <amit.shah@qumranet.com>
---
qemu/hw/rtl8139.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu/hw/rtl8139.c b/qemu/hw/rtl8139.c
index e4df58f..56ed9c7 100644
--- a/qemu/hw/rtl8139.c
+++ b/qemu/hw/rtl8139.c
@@ -3415,8 +3415,8 @@ PCIDevice *pci_rtl8139_init(PCIBus *bus, NICInfo *nd, int devfn)
return NULL;
pci_conf = d->dev.config;
- pci_conf[0x00] = 0xec; /* Realtek 8139 */
- pci_conf[0x01] = 0x10;
+ pci_conf[0x00] = pci_conf[0x2c] = 0xec; /* Realtek 8139 */
+ pci_conf[0x01] = pci_conf[0x2d] = 0x10;
pci_conf[0x02] = 0x39;
pci_conf[0x03] = 0x81;
pci_conf[0x04] = 0x05; /* command = I/O space, Bus Master */
--
1.5.5.1
next prev parent reply other threads:[~2008-05-26 10:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-26 10:36 [Qemu-devel] PCI: Add subsystem vendor IDs and mask writes to RO bits Amit Shah
2008-05-26 10:36 ` [Qemu-devel] [PATCH 01/14] QEMU: Fill in PCI subsystem vendor id for acpi Amit Shah
2008-05-26 10:36 ` [Qemu-devel] [PATCH 1/2] QEMU: Mask writes to RO bits in the status reg of PCI config space Amit Shah
2008-05-26 10:36 ` [Qemu-devel] [PATCH 02/14] QEMU: Fill in PCI subsystem vendor id for cirrus_vga Amit Shah
2008-05-26 10:36 ` [Qemu-devel] [PATCH 2/2] QEMU: Mask writes to RO bits in the command reg of PCI config space Amit Shah
2008-05-26 10:36 ` [Qemu-devel] [PATCH 03/14] QEMU: Fill in PCI subsystem vendor id for e1000 Amit Shah
2008-05-26 10:36 ` [Qemu-devel] [PATCH 04/14] QEMU: Fill in PCI subsystem vendor id for eepro100 Amit Shah
2008-05-26 10:36 ` [Qemu-devel] [PATCH 05/14] QEMU: Fill in PCI subsystem vendor id for ide Amit Shah
2008-05-26 10:36 ` [Qemu-devel] [PATCH 06/14] QEMU: Fill in PCI subsystem vendor id for LSI Amit Shah
2008-05-26 10:36 ` [Qemu-devel] [PATCH 07/14] QEMU: Fill in PCI subsystem vendor id for ne2000 Amit Shah
2008-05-26 10:36 ` [Qemu-devel] [PATCH 08/14] QEMU: Fill in PCI subsystem vendor id for pcnet Amit Shah
2008-05-26 10:36 ` [Qemu-devel] [PATCH 09/14] QEMU: Fill in PCI subsystem vendor id for piix_pci Amit Shah
2008-05-26 10:36 ` Amit Shah [this message]
2008-05-26 10:36 ` [Qemu-devel] [PATCH 11/14] QEMU: Fill in PCI subsystem vendor id for usb-ohci Amit Shah
2008-05-26 10:36 ` [Qemu-devel] [PATCH 12/14] QEMU: Fill in PCI subsystem vendor id for usb-uhci Amit Shah
2008-05-26 10:36 ` [Qemu-devel] [PATCH 13/14] QEMU: Fill in PCI subsystem vendor id for versatile_pci Amit Shah
2008-05-26 10:36 ` [Qemu-devel] [PATCH 14/14] QEMU: Fill in PCI subsystem vendor id for vga Amit Shah
2008-05-26 18:36 ` [Qemu-devel] [PATCH 03/14] QEMU: Fill in PCI subsystem vendor id for e1000 M. Warner Losh
2008-05-27 15:01 ` Amit Shah
2008-05-26 18:33 ` [Qemu-devel] [PATCH 1/2] QEMU: Mask writes to RO bits in the status reg of PCI config space M. Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1211798213-4187-13-git-send-email-amit.shah@qumranet.com \
--to=amit.shah@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).