From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K3uJF-0007lV-Sz
	for qemu-devel@nongnu.org; Wed, 04 Jun 2008 10:49:54 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K3uJE-0007gw-5F
	for qemu-devel@nongnu.org; Wed, 04 Jun 2008 10:49:53 -0400
Received: from [199.232.76.173] (port=42195 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K3uJD-0007ge-OI
	for qemu-devel@nongnu.org; Wed, 04 Jun 2008 10:49:51 -0400
Received: from g5t0009.atlanta.hp.com ([15.192.0.46]:19142)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <alex.williamson@hp.com>) id 1K3uJD-0004vA-HX
	for qemu-devel@nongnu.org; Wed, 04 Jun 2008 10:49:51 -0400
Subject: Re: [Qemu-devel] [PATCH] ide: fix ATAPI read drive structure
	command (v3)
From: Alex Williamson <alex.williamson@hp.com>
In-Reply-To: <4846A83B.2050000@us.ibm.com>
References: <1211865917.8201.56.camel@bling>
	<B34520FE-89D9-4D93-A0D6-48C4DED102EA@suse.de>
	<1212004084.6821.30.camel@lappy>
	<13EAABC4-ED0C-4B91-9DF4-9486F0A1259E@suse.de>
	<1212418735.6656.32.camel@lappy>
	<8F70DBBA-DB05-4B03-886B-A2182F3A3AC6@suse.de>
	<1212444720.13411.12.camel@lappy> <1212446737.13411.15.camel@lappy>
	<4845786C.5090908@codemonkey.ws> <1212582648.10496.134.camel@bling>
	<4846A83B.2050000@us.ibm.com>
Content-Type: text/plain
Date: Wed, 04 Jun 2008 08:49:35 -0600
Message-Id: <1212590975.6711.8.camel@lappy>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On Wed, 2008-06-04 at 09:35 -0500, Anthony Liguori wrote:
> I think the automatic probing is good, but we should have a -drive 
> parameter that allows the cd type to explicitly be set to either CDROM 
> or DVD.  This can be done in a follow-up patch though.  I did some 
> testing with Windows and this patch seems to do the right thing.

It seems like both places the check is used we're concerned about the
type of media inserted.  I don't know enough about ISO formats, but
perhaps we could identify it as iso9660 vs udf at some level.  Thanks
for the comments, review, and testing.

	Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.