From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K8tXx-0007FE-5Q for qemu-devel@nongnu.org; Wed, 18 Jun 2008 05:01:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K8tXw-0007F2-BH for qemu-devel@nongnu.org; Wed, 18 Jun 2008 05:01:40 -0400 Received: from [199.232.76.173] (port=46873 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K8tXv-0007Es-WB for qemu-devel@nongnu.org; Wed, 18 Jun 2008 05:01:40 -0400 Received: from ecfrec.frec.bull.fr ([129.183.4.8]:44718) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K8tXu-0000rO-AO for qemu-devel@nongnu.org; Wed, 18 Jun 2008 05:01:39 -0400 Subject: Re: [Qemu-devel] [PATCH] NBD dead code elimination From: Laurent Vivier In-Reply-To: <20080618071506.GD1486@tapir> References: <20080618071506.GD1486@tapir> Content-Type: text/plain; charset=UTF-8 Date: Wed, 18 Jun 2008 11:00:53 +0200 Message-Id: <1213779653.3854.7.camel@frecb07144> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi, I don't know if it is a good idea to remove this code, perhaps it can be useful one day if we want to add the nbd-client functionality in qemu-nbd (my patch, using unix socket, already does). Regards, Laurent Le mercredi 18 juin 2008 =C3=A0 02:15 -0500, Carlo Marcelo Arenas Belon a =C3=A9crit : > The following patch, removes tcp_socket_outgoing which is not being use= d by > the current implementation, neither the proposed unix socket patches. >=20 > This avoids the following compile time warning : >=20 > nbd.c:99: warning: 'tcp_socket_outgoing' defined but not used >=20 > Carlo > --- --=20 ------------- Laurent.Vivier@bull.net --------------- "The best way to predict the future is to invent it." - Alan Kay