From: Laurent Vivier <Laurent.Vivier@bull.net>
To: Kevin Wolf <kwolf@suse.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qcow2: improve I/O performance with cache=off
Date: Wed, 25 Jun 2008 10:59:51 +0200 [thread overview]
Message-ID: <1214384391.5798.1.camel@frecb07144> (raw)
In-Reply-To: <48620515.4070306@suse.de>
Le mercredi 25 juin 2008 à 10:43 +0200, Kevin Wolf a écrit :
> Hi Laurent,
>
> Laurent Vivier schrieb:
> > I modify this patch according Avi comments, and I'll repost it.
> >
> > Thank you for your comments.
>
> It's certainly a good idea to add the change suggested by Avi. But don't
> you think you'd better make a second patch out of it, on top of this
> one? I feel that the patch to get_cluster_offset might not be too small
> for itself.
Yes, you're right. So I'll resend this patch in a serie.
> Oh, and while you're at it... ;-) I think this function could use at
> least some more comments, and splitting out some parts as new functions
> could also help with its readability.
I'll think about that. But adding more functions can also be bad for the
readability.
Thank you,
Laurent
--
------------- Laurent.Vivier@bull.net ---------------
"The best way to predict the future is to invent it."
- Alan Kay
prev parent reply other threads:[~2008-06-25 9:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 14:38 [Qemu-devel] [PATCH] qcow2: improve I/O performance with cache=off Laurent Vivier
2008-06-23 2:50 ` Avi Kivity
2008-06-24 15:40 ` Kevin Wolf
2008-06-24 16:40 ` Laurent Vivier
2008-06-25 8:43 ` Kevin Wolf
2008-06-25 8:59 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214384391.5798.1.camel@frecb07144 \
--to=laurent.vivier@bull.net \
--cc=kwolf@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).