qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>
Subject: [Qemu-devel] [PATCH 3/6] kvm: qemu: revert "fix power management timer overflow handling"
Date: Thu, 17 Jul 2008 16:19:37 -0500	[thread overview]
Message-ID: <1216329580-20804-3-git-send-email-aliguori@us.ibm.com> (raw)
In-Reply-To: <1216329580-20804-1-git-send-email-aliguori@us.ibm.com>

From: Avi Kivity <avi@qumranet.com>

The fix is bogus, causing sci to be deferred for longer and longer.

Noticed by Alex Williamson.

Signed-off-by: Avi Kivity <avi@qumranet.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

diff --git a/hw/acpi.c b/hw/acpi.c
index c305702..e3cd8d7 100644
--- a/hw/acpi.c
+++ b/hw/acpi.c
@@ -109,7 +109,6 @@ static void pm_update_sci(PIIX4PMState *s)
     if ((s->pmen & TMROF_EN) && !(pmsts & TMROF_EN)) {
         expire_time = muldiv64(s->tmr_overflow_time, ticks_per_sec, PM_FREQ);
         qemu_mod_timer(s->tmr_timer, expire_time);
-        s->tmr_overflow_time += 0x800000;
     } else {
         qemu_del_timer(s->tmr_timer);
     }

  parent reply	other threads:[~2008-07-17 21:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-17 21:19 [Qemu-devel] [PATCH 1/6] kvm: qemu: fix screendump with multiple consoles Anthony Liguori
2008-07-17 21:19 ` [Qemu-devel] [PATCH 2/6] kvm: qemu: force screen resize if a display buffer does not exist Anthony Liguori
2008-07-17 21:19 ` Anthony Liguori [this message]
2008-07-17 21:19 ` [Qemu-devel] [PATCH 4/6] kvm: qemu: revert ""QEMU keyboard issue with Gujin-2.2", by Etienne Lorrain." Anthony Liguori
2008-07-17 21:43   ` Even Rouault
2008-07-17 21:47   ` [Qemu-devel] " Jan Kiszka
2008-07-17 21:58     ` Anthony Liguori
2008-07-17 21:19 ` [Qemu-devel] [PATCH 5/6] kvm: qemu: improve scsi dma speed by increasing the dma buffer size Anthony Liguori
2008-07-20  2:37   ` Anthony Liguori
2008-07-17 21:19 ` [Qemu-devel] [PATCH 6/6] kvm: qemu: fix vga screendump Anthony Liguori
2008-07-19 14:36   ` andrzej zaborowski
2008-07-20  2:33     ` Anthony Liguori
2008-07-20 17:07       ` andrzej zaborowski
2008-07-20 18:39         ` Anthony Liguori
2008-07-20 19:28           ` andrzej zaborowski
2008-07-20 19:46             ` Anthony Liguori
2008-07-20 20:08               ` andrzej zaborowski
2008-07-20 21:53                 ` Anthony Liguori
2008-07-20 21:56                 ` Anthony Liguori
2008-07-21  2:00                   ` Jamie Lokier
2008-07-17 21:39 ` [Qemu-devel] [PATCH 0/6] Various fixes from KVM tree Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1216329580-20804-3-git-send-email-aliguori@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).