Re: [Qemu-devel] [PATCH 00/26] ccid and libcacard fixes for windows/mingw

[Alon Levy <alevy@redhat.com>]

> This series:
> 1. fixes windows guests to show the ccid device
> 2. changes libcacard to use glib
> 3. makes libcacard build under mingw
> 4. does some cleanups
5. adds three debugging environment variables: QEMU_CCID_PASSTHRU_DEBUG, QEMU_CCID_DEBUG and LIBCACARD_DEBUG
The reason for using those is that it makes it easier to use with libvirt, which already supports environment variables on qemu machines via an extended xml namespace.

Additionally, please ignore 26/26, I'll drop it, didn't mean to send it. (it's a nop anyway).

> 
> It contains a few patches already posted to the list (the two Jim
> Meyering patches) which were already acked.
> 
> I'll make a pull request once this had some time to be reviewed.
> 
> Tested with a fedora and windows 7 guest.
> 
> The main non cleanup patches are:
>   hw/usb/dev-smartcard-reader: support windows guest
>   libcacard: correct T0 historical bytes size
> 
> 
> Alon Levy (15):
>   hw/ccid-card-passthru.c: add atr check
>   ccid-card-passthru, dev-smartcard-reader: add debug environment
>     variables
>   hw/usb/dev-smartcard-reader.c: white space fixes
>   hw/usb/dev-smartcard-reader.c: nicer debug messages
>   hw/usb/dev-smartcard-reader.c: remove aborts (never triggered, but
>     just in case)
>   hw/usb/dev-smartcard-reader.c: define structs for CCID_Parameter
>     internals
>   hw/usb/dev-smartcard-reader.c: copy atr's protocol to ccid's
>     parameters (adds todo's)
>   hw/usb/dev-smartcard-reader.c: dwFeadvertise support for T=0 only
>   hw/usb/dev-smartcard-reader: support windows guest
>   dev-smartcard-reader: reuse usb.h definitions
>   libcacard/vreader: add debugging messages for apdu
>   libcacard: change default ATR
>   libcacard: move atr setting from macro to function
>   dev-smartcard-reader: empty implementation for Mechanical (fail
>     correctly)
>   libcacard/cac.c: questionable change to single return of big switch
>     functions
> 
> Jim Meyering (2):
>   ccid: make backend_enum_table "static const" and adjust users
>   ccid: declare DEFAULT_ATR table to be "static const"
> 
> Marc-André Lureau (9):
>   libcacard: correct T0 historical bytes size
>   ccid-card-emul: do not crash if backend is not provided
>   libcacard: use system config directory for nss db on win32
>   util: move socket_init() to osdep.c
>   build-sys: must link with -fstack-protector
>   libcacard: fix mingw64 cross-compilation
>   libcacard: split vscclient main() from socket reading
>   libcacard: vscclient to use QemuThread for portability
>   libcacard: teach vscclient to use GMainLoop for portability
> 
>  Makefile                      |   8 +-
>  Makefile.objs                 |   1 +
>  configure                     |   8 +-
>  hw/ccid-card-emulated.c       |   9 +-
>  hw/ccid-card-passthru.c       |  77 ++++++-
>  hw/usb/dev-smartcard-reader.c | 259 ++++++++++++++++-----
>  libcacard/cac.c               |  80 ++++---
>  libcacard/cac.h               |   8 +
>  libcacard/vcard_emul_nss.c    |  29 ++-
>  libcacard/vcardt.c            |  40 ++++
>  libcacard/vcardt.h            |   7 +-
>  libcacard/vreader.c           |  89 ++++++++
>  libcacard/vscclient.c         | 506
>  +++++++++++++++++++++++++-----------------
>  rules.mak                     |   4 +-
>  util/osdep.c                  |  23 ++
>  util/qemu-sockets.c           |  24 --
>  16 files changed, 846 insertions(+), 326 deletions(-)
>  create mode 100644 libcacard/vcardt.c
> 
> --
> 1.8.1.4
> 
> 
>