[Qemu-devel] [PATCH] qemu: set focus to monitor to ask password if line is multiplexed

[Qemu-devel] [PATCH] qemu: set focus to monitor to ask password if line is multiplexed

[Laurent Vivier]

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

This patch allows to display the "Password:" prompt if we use encrypted
disk with "-nographic" option.

It also modifies management of "-nographic" to not override user's
choices for "-serial", "-parallel" and "-monitor".

When qemu has to ask a password with "-nographic" with a multiplexed
serial interface, it forces the focus to the monitor and restore
original focus after.

Regards,
Laurent
-- 
----------------- Laurent.Vivier@bull.net  ------------------
  "La perfection est atteinte non quand il ne reste rien à
ajouter mais quand il ne reste rien à enlever." Saint Exupéry

[-- Attachment #2: nographic.patch --]
[-- Type: text/x-vhdl, Size: 2345 bytes --]

---
 monitor.c |   17 +++++++++++++++--
 vl.c      |   12 +++++++++---
 2 files changed, 24 insertions(+), 5 deletions(-)

Index: qemu/vl.c
===================================================================
--- qemu.orig/vl.c	2008-07-31 12:52:26.000000000 +0200
+++ qemu/vl.c	2008-07-31 12:53:04.000000000 +0200
@@ -8381,9 +8381,6 @@ int main(int argc, char **argv)
                 }
                 break;
             case QEMU_OPTION_nographic:
-                serial_devices[0] = "stdio";
-                parallel_devices[0] = "null";
-                monitor_device = "stdio";
                 nographic = 1;
                 break;
 #ifdef CONFIG_CURSES
@@ -8781,6 +8778,15 @@ int main(int argc, char **argv)
         }
     }
 
+    if (nographic) {
+       if (serial_device_index == 0)
+           serial_devices[0] = "stdio";
+       if (parallel_device_index == 0)
+           parallel_devices[0] = "null";
+       if (strncmp(monitor_device, "vc", 2) == 0)
+           monitor_device = "stdio";
+    }
+
 #ifndef _WIN32
     if (daemonize) {
 	pid_t pid;
Index: qemu/monitor.c
===================================================================
--- qemu.orig/monitor.c	2008-07-31 12:52:26.000000000 +0200
+++ qemu/monitor.c	2008-07-31 12:57:44.000000000 +0200
@@ -2722,12 +2722,19 @@ void monitor_readline(const char *prompt
                       char *buf, int buf_size)
 {
     int i;
+    int old_focus[MAX_MON];
 
     if (is_password) {
-        for (i = 0; i < MAX_MON; i++)
-            if (monitor_hd[i] && monitor_hd[i]->focus == 0)
+        for (i = 0; i < MAX_MON; i++) {
+            old_focus[i] = 0;
+            if (monitor_hd[i]) {
+                old_focus[i] = monitor_hd[i]->focus;
+                monitor_hd[i]->focus = 0;
                 qemu_chr_send_event(monitor_hd[i], CHR_EVENT_FOCUS);
+            }
+        }
     }
+
     readline_start(prompt, is_password, monitor_readline_cb, NULL);
     monitor_readline_buf = buf;
     monitor_readline_buf_size = buf_size;
@@ -2735,4 +2742,10 @@ void monitor_readline(const char *prompt
     while (monitor_readline_started) {
         main_loop_wait(10);
     }
+    /* restore original focus */
+    if (is_password) {
+        for (i = 0; i < MAX_MON; i++)
+            if (old_focus[i])
+                monitor_hd[i]->focus = old_focus[i];
+    }
 }

[Qemu-devel] Re: [PATCH] qemu: set focus to monitor to ask password if line is multiplexed

[Anthony Liguori]

Laurent Vivier wrote:
> This patch allows to display the "Password:" prompt if we use encrypted
> disk with "-nographic" option.
>
> It also modifies management of "-nographic" to not override user's
> choices for "-serial", "-parallel" and "-monitor".
>
> When qemu has to ask a password with "-nographic" with a multiplexed
> serial interface, it forces the focus to the monitor and restore
> original focus after.
>
> Regards,
> Laurent
>   

Please include a Signed-off-by line in your patch.  Otherwise looks good.

Regards,

Anthony Liguori

[Qemu-devel] Re: [PATCH] qemu: set focus to monitor to ask password if line is multiplexed

[Laurent Vivier]

Le vendredi 01 août 2008 à 09:53 -0500, Anthony Liguori a écrit :
> Laurent Vivier wrote:
> > This patch allows to display the "Password:" prompt if we use encrypted
> > disk with "-nographic" option.
> >
> > It also modifies management of "-nographic" to not override user's
> > choices for "-serial", "-parallel" and "-monitor".
> >
> > When qemu has to ask a password with "-nographic" with a multiplexed
> > serial interface, it forces the focus to the monitor and restore
> > original focus after.
> >
> > Regards,
> > Laurent
> >   
> 
> Please include a Signed-off-by line in your patch.  Otherwise looks good.

Signed-off-by: Laurent Vivier <Laurent.Vivier@bull.net>

Laurent
-- 
----------------- Laurent.Vivier@bull.net  ------------------
  "La perfection est atteinte non quand il ne reste rien à
ajouter mais quand il ne reste rien à enlever." Saint Exupéry