From: Dietmar Maurer <dietmar@proxmox.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v3] yield_until_fd_readable: make it work with any AioContect
Date: Thu, 24 Oct 2019 06:58:25 +0200 (CEST) [thread overview]
Message-ID: <1219145809.2.1571893105014@webmail.proxmox.com> (raw)
In-Reply-To: <20191023142258.GE9574@stefanha-x1.localdomain>
> > + aio_set_fd_handler(ctx, fd, false, (IOHandler *)qemu_coroutine_enter,
> > + NULL, NULL, qemu_coroutine_self());
>
> This cast is unsafe. If qemu_coroutine_enter()'s prototype is changed
> there will be no compiler warning that the prototypes are now
> incompatible.
>
> Please keep fd_coroutine_enter() so the code is type-safe.
OK. Sent v4 with suggested changes.
prev parent reply other threads:[~2019-10-24 5:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 8:50 [PATCH v3] yield_until_fd_readable: make it work with any AioContect Dietmar Maurer
2019-10-23 14:22 ` Stefan Hajnoczi
2019-10-24 4:58 ` Dietmar Maurer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219145809.2.1571893105014@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).