From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ECF0CA9EAF for ; Thu, 24 Oct 2019 05:08:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AAC520679 for ; Thu, 24 Oct 2019 05:08:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AAC520679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=proxmox.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNVMO-0004mu-B0 for qemu-devel@archiver.kernel.org; Thu, 24 Oct 2019 01:08:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32898) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNVLS-0003Et-KC for qemu-devel@nongnu.org; Thu, 24 Oct 2019 01:07:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNVLR-0002Bx-Lj for qemu-devel@nongnu.org; Thu, 24 Oct 2019 01:07:34 -0400 Received: from proxmox-new.maurer-it.com ([212.186.127.180]:6859) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iNVLR-0002Ap-Er for qemu-devel@nongnu.org; Thu, 24 Oct 2019 01:07:33 -0400 Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AA4FD46576; Thu, 24 Oct 2019 06:58:26 +0200 (CEST) Date: Thu, 24 Oct 2019 06:58:25 +0200 (CEST) From: Dietmar Maurer To: Stefan Hajnoczi Message-ID: <1219145809.2.1571893105014@webmail.proxmox.com> In-Reply-To: <20191023142258.GE9574@stefanha-x1.localdomain> References: <20191021085055.30852-1-dietmar@proxmox.com> <20191023142258.GE9574@stefanha-x1.localdomain> Subject: Re: [PATCH v3] yield_until_fd_readable: make it work with any AioContect MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.2-Rev14 X-Originating-Client: open-xchange-appsuite X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.186.127.180 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Dietmar Maurer Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > > + aio_set_fd_handler(ctx, fd, false, (IOHandler *)qemu_coroutine_enter, > > + NULL, NULL, qemu_coroutine_self()); > > This cast is unsafe. If qemu_coroutine_enter()'s prototype is changed > there will be no compiler warning that the prototypes are now > incompatible. > > Please keep fd_coroutine_enter() so the code is type-safe. OK. Sent v4 with suggested changes.