qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ryan Harper <ryanh@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: Ryan Harper <ryanh@us.ibm.com>,
	kvm@vger.kernel.org, Ian Kirk <blob@blob.co.uk>
Subject: [Qemu-devel] [PATCH 1/2] Fix text console size/resize when using curses
Date: Fri, 22 Aug 2008 13:03:40 -0500	[thread overview]
Message-ID: <1219428221-22947-2-git-send-email-ryanh@us.ibm.com> (raw)
In-Reply-To: <1219428221-22947-1-git-send-email-ryanh@us.ibm.com>

The current console output is broken in curses mode size the default starting
size might not match the launching terminal size.  Change initial size to be
based on the terminal.  Also, resize events fail to ensure that both the text
console and curses display areas are the same size; this causes broken output
like:

QEMU 0.9.1 monitor - type 'help' for more information
                    (qemu)
                                            (qemu)
                                                                (qemu)

To fix this, ensure that the display width and the text area width are sync for
text consoles on refresh; also force a resize event whenever we invalidate the
text console.

Signed-off-by: Ryan Harper <ryanh@us.ibm.com>

diff --git a/console.c b/console.c
index 1c94980..89bdc52 100644
--- a/console.c
+++ b/console.c
@@ -608,6 +608,9 @@ static void console_refresh(TextConsole *s)
         s->text_y[0] = 0;
         s->text_x[1] = s->width - 1;
         s->text_y[1] = s->height - 1;
+        /* ensure that textconsole area is the same size as the display */
+        s->g_width = s->ds->width;
+        s->g_height = s->ds->height;
         s->cursor_invalidate = 1;
         return;
     }
@@ -1158,6 +1161,8 @@ static void text_console_invalidate(void *opaque)
     TextConsole *s = (TextConsole *) opaque;
 
     console_refresh(s);
+    /* resize if needed */
+    text_console_resize(s);
 }
 
 static void text_console_update(void *opaque, console_ch_t *chardata)
diff --git a/curses.c b/curses.c
index d09eff2..a8972f4 100644
--- a/curses.c
+++ b/curses.c
@@ -362,8 +362,8 @@ void curses_display_init(DisplayState *ds, int full_screen)
     ds->data = (void *) screen;
     ds->linesize = 0;
     ds->depth = 0;
-    ds->width = 640;
-    ds->height = 400;
+    ds->width = COLS * FONT_WIDTH;
+    ds->height = LINES * FONT_HEIGHT;
     ds->dpy_update = curses_update;
     ds->dpy_resize = curses_resize;
     ds->dpy_refresh = curses_refresh;
@@ -371,6 +371,6 @@ void curses_display_init(DisplayState *ds, int full_screen)
 
     invalidate = 1;
 
-    /* Standard VGA initial text mode dimensions */
-    curses_resize(ds, 80, 25);
+    /* setup up initial display size based on terminal settings */
+    curses_resize(ds, COLS, LINES);
 }

  reply	other threads:[~2008-08-22 18:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-22 18:03 [Qemu-devel] [PATCH 0/2] Fix monitor console in curses mode Ryan Harper
2008-08-22 18:03 ` Ryan Harper [this message]
2008-08-22 22:40   ` [Qemu-devel] [PATCH 1/2] Fix text console size/resize when using curses andrzej zaborowski
2008-08-22 22:56     ` Ryan Harper
2008-08-22 18:03 ` [Qemu-devel] [PATCH 2/2] Fix typo in console.c comment Ryan Harper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1219428221-22947-2-git-send-email-ryanh@us.ibm.com \
    --to=ryanh@us.ibm.com \
    --cc=blob@blob.co.uk \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).