From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: qemu-devel@nongnu.org
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
Paul Brook <paul@codesourcery.com>
Subject: [Qemu-devel] [PATCH] Fix vfork() syscall emulation
Date: Sat, 23 Aug 2008 03:18:25 +0300 [thread overview]
Message-ID: <1219450705-1376-1-git-send-email-kirill@shutemov.name> (raw)
vfork() is a kind of fork, not thread despite CLONE_VM
Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
---
linux-user/syscall.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index fd4890e..2abdc83 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -2787,7 +2787,7 @@ static int do_fork(CPUState *env, unsigned int flags, abi_ulong newsp,
sigset_t sigmask;
#endif
- if (flags & CLONE_VM) {
+ if (!(flags & CLONE_VFORK) && flags & CLONE_VM) {
#if defined(USE_NPTL)
new_thread_info info;
pthread_attr_t attr;
@@ -2856,8 +2856,8 @@ static int do_fork(CPUState *env, unsigned int flags, abi_ulong newsp,
#endif
#endif
} else {
- /* if no CLONE_VM, we consider it is a fork */
- if ((flags & ~(CSIGNAL | CLONE_NPTL_FLAGS2)) != 0)
+ /* we consider it is a fork or vfork */
+ if ((flags & ~(CSIGNAL | CLONE_NPTL_FLAGS2 | CLONE_VFORK | CLONE_VM)) != 0)
return -EINVAL;
fork_start();
ret = fork();
--
1.5.6.5.GIT
next reply other threads:[~2008-08-23 0:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-23 0:18 Kirill A. Shutemov [this message]
2008-08-24 14:47 ` [Qemu-devel] [PATCH] Fix vfork() syscall emulation Jamie Lokier
2008-08-24 15:51 ` Kirill A. Shutemov
-- strict thread matches above, loose matches on Subject: below --
2008-08-24 15:54 Kirill A. Shutemov
2008-09-08 14:03 Kirill A. Shutemov
2008-09-18 15:06 Kirill A. Shutemov
2008-09-20 2:56 ` andrzej zaborowski
2008-09-20 6:45 ` Kirill A. Shutemov
2008-09-20 12:45 ` andrzej zaborowski
2008-09-20 13:11 ` Kirill A. Shutemov
2008-09-20 13:52 ` andrzej zaborowski
2008-09-20 14:20 ` Kirill A. Shutemov
2008-09-20 14:35 ` andrzej zaborowski
2008-09-20 14:38 ` Kirill A. Shutemov
2008-09-20 7:12 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219450705-1376-1-git-send-email-kirill@shutemov.name \
--to=kirill@shutemov.name \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).