From: "J. Mayer" <l_indien@magic.fr>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5083] PPC: Switch a few instructions to TCG
Date: Mon, 25 Aug 2008 00:08:17 +0200 [thread overview]
Message-ID: <1219615697.8118.30.camel@localhost> (raw)
In-Reply-To: <E1KXKu7-0006xf-Iy@cvs.savannah.gnu.org>
On Sun, 2008-08-24 at 19:05 +0000, Aurelien Jarno wrote:
> Revision: 5083
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5083
> Author: aurel32
> Date: 2008-08-24 19:05:35 +0000 (Sun, 24 Aug 2008)
>
> Log Message:
> -----------
> PPC: Switch a few instructions to TCG
It seems like you forgot to consider that I might be working on this
subject, as I announced here last month and care if you break my work in
any way.
Then, you also "forgot" to wait for the fixes needed to address
regression that have been introduced by previous inconsidered commits in
PowerPC emulation: I also said that this was the _first thing_ to be
done before anything else in PowePC code.
Then, I can be sure that you "forgot" to test if your patch breaks any
PowerPC targets, as some do not run now...
Last but not least, you also "forgot" to submit your patch, wait for
comments, reviews, tests...
All this is unacceptable; furthermore, just giving a quick look, there
seem to be many things that should never have been commited as-is and
have to be fixed before this set of could eventually be merged.
Please revert_ now_.
Thanks by advance.
--
J. Mayer <l_indien@magic.fr>
Never organized
next prev parent reply other threads:[~2008-08-24 22:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-24 19:05 [Qemu-devel] [5083] PPC: Switch a few instructions to TCG Aurelien Jarno
2008-08-24 22:08 ` J. Mayer [this message]
2008-08-24 23:17 ` Aurelien Jarno
2008-08-24 23:27 ` Andreas Färber
2008-08-25 22:25 ` J. Mayer
2008-08-26 1:22 ` Johannes Schindelin
2008-08-27 17:33 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219615697.8118.30.camel@localhost \
--to=l_indien@magic.fr \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).