From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KXNl0-0007lm-BI for qemu-devel@nongnu.org; Sun, 24 Aug 2008 18:08:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KXNky-0007kQ-OT for qemu-devel@nongnu.org; Sun, 24 Aug 2008 18:08:21 -0400 Received: from [199.232.76.173] (port=48668 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KXNky-0007kN-LY for qemu-devel@nongnu.org; Sun, 24 Aug 2008 18:08:20 -0400 Received: from brazzaville.magic.fr ([62.210.190.9]:48328) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KXNky-0005b2-8t for qemu-devel@nongnu.org; Sun, 24 Aug 2008 18:08:20 -0400 Received: from [192.168.0.2] (ppp-36.net-123.static.magiconline.fr [80.118.184.36]) by brazzaville.magic.fr (8.12.11.20060308/8.11.6) with ESMTP id m7OM83Jt013885 for ; Mon, 25 Aug 2008 00:08:04 +0200 Subject: Re: [Qemu-devel] [5083] PPC: Switch a few instructions to TCG From: "J. Mayer" In-Reply-To: References: Content-Type: text/plain Date: Mon, 25 Aug 2008 00:08:17 +0200 Message-Id: <1219615697.8118.30.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Sun, 2008-08-24 at 19:05 +0000, Aurelien Jarno wrote: > Revision: 5083 > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5083 > Author: aurel32 > Date: 2008-08-24 19:05:35 +0000 (Sun, 24 Aug 2008) > > Log Message: > ----------- > PPC: Switch a few instructions to TCG It seems like you forgot to consider that I might be working on this subject, as I announced here last month and care if you break my work in any way. Then, you also "forgot" to wait for the fixes needed to address regression that have been introduced by previous inconsidered commits in PowerPC emulation: I also said that this was the _first thing_ to be done before anything else in PowePC code. Then, I can be sure that you "forgot" to test if your patch breaks any PowerPC targets, as some do not run now... Last but not least, you also "forgot" to submit your patch, wait for comments, reviews, tests... All this is unacceptable; furthermore, just giving a quick look, there seem to be many things that should never have been commited as-is and have to be fixed before this set of could eventually be merged. Please revert_ now_. Thanks by advance. -- J. Mayer Never organized