From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzWUJ-0001Ga-RK for qemu-devel@nongnu.org; Mon, 01 Jun 2015 16:39:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzWUG-00022r-17 for qemu-devel@nongnu.org; Mon, 01 Jun 2015 16:39:11 -0400 Received: from mx3-phx2.redhat.com ([209.132.183.24]:33219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzWUF-00022l-P3 for qemu-devel@nongnu.org; Mon, 01 Jun 2015 16:39:07 -0400 Date: Mon, 1 Jun 2015 16:39:03 -0400 (EDT) From: Paolo Bonzini Message-ID: <1219952010.12863824.1433191143645.JavaMail.zimbra@redhat.com> In-Reply-To: <556CC179.3020400@twiddle.net> References: <74cc0d2f8d1d9d52638a1b3633e1a861b51907f4.1433052532.git.crosthwaite.peter@gmail.com> <556CB18A.6070305@twiddle.net> <556CB7DE.1080006@redhat.com> <556CC179.3020400@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 10/34] include/exec: Split target_long def to new header List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: peter maydell , Peter Crosthwaite , qemu-devel@nongnu.org, Peter Crosthwaite , edgar iglesias , afaerber@suse.de > > He later #defines target_{,u}long to e.g. arm_target_{,u}long. > > Ok, here's where I'm not liking things. It shouldn't be a typedef in some > places and a define others. From this description, it sounds like it ought > to always be a define. target_long expands to arm_target_long, which in turn is a typedef provided by include/exec/target_long.h. See the "multi-arch"izing patches for arm and microblaze. Paolo