From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: pbonzini@redhat.com, den@openvz.org,
qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] nbd/server: fix NBD_CMD_CACHE
Date: Wed, 3 Oct 2018 09:57:30 -0500 [thread overview]
Message-ID: <121a81ed-7932-b96c-cc84-60b82725d8e1@redhat.com> (raw)
In-Reply-To: <20181003144738.70670-1-vsementsov@virtuozzo.com>
On 10/3/18 9:47 AM, Vladimir Sementsov-Ogievskiy wrote:
> We should not go to structured-read branch on CACHE command, fix that.
>
> Bug intoroduced in bc37b06a5cde24 "nbd/server: introduce NBD_CMD_CACHE"
s/intoroduced/introduced/
> with the whole feature and affects 3.0.0 release.
Ouch. It's because I don't have an NBD client that can issue the
command, so the server side got released without sufficient testing. Is
there some way we could enhance qemu-io as NBD client to issue such a
command?
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
CC: qemu-stable@nongnu.org
Reviewed-by: Eric Blake <eblake@redhat.com>
Will queue through my NBD tree.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-10-03 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 14:47 [Qemu-devel] [PATCH] nbd/server: fix NBD_CMD_CACHE Vladimir Sementsov-Ogievskiy
2018-10-03 14:57 ` Eric Blake [this message]
2018-10-03 15:10 ` Vladimir Sementsov-Ogievskiy
2018-10-04 13:02 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2018-10-04 14:29 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=121a81ed-7932-b96c-cc84-60b82725d8e1@redhat.com \
--to=eblake@redhat.com \
--cc=den@openvz.org \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).