From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43460)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WzqJp-00017e-G2
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 12:45:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WzqJh-0004YH-W8
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 12:45:09 -0400
Received: from mx6-phx2.redhat.com ([209.132.183.39]:56651)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WzqJh-0004VC-PK
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 12:45:01 -0400
Date: Wed, 25 Jun 2014 12:44:58 -0400 (EDT)
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <122055914.32517283.1403714698790.JavaMail.zimbra@redhat.com>
In-Reply-To: <7760835F-C1F1-4023-960D-A70096465EBD@cisco.com>
References: <A459CE38-2929-47A2-8683-8D7EAF0325C0@cisco.com>
	<A8A6A4DC-E474-45BB-A583-F73405F91F34@cisco.com>
	<20140625142704.GC15277@redhat.com>
	<7B7FFD16-82ED-4D0E-8B83-A6448DC9A344@cisco.com>
	<20140625152936.GB15720@redhat.com>
	<F6EF1C72-B3B7-4DAA-8CDB-0BD591E9E64D@cisco.com>
	<20140625155038.GG15720@redhat.com>
	<7760835F-C1F1-4023-960D-A70096465EBD@cisco.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] vhost-user: broken mem regions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Damjan Marion (damarion)" <damarion@cisco.com>
Cc: qemu-devel@nongnu.org, Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>, "Michael S. Tsirkin" <mst@redhat.com>

> nregions: 4
> region:
> =09gpa =3D 0x100000000
> =09size =3D 3221225472
> =09ua =3D 0x2aab6ac00000

High memory, above 3 gigabytes.

> region:
> =09gpa =3D 0xFFFC0000
> =09size =3D 262144
> =09ua =3D 0x7fc13d200000

This is the BIOS.  There shouldn't be any FD for this one, it
is not allocated in hugetlbfs.

> region:
> =09gpa =3D 0x0
> =09size =3D 655360
> =09ua =3D 0x2aaaaac00000
> region:
> =09gpa =3D 0xC0000
> =09size =3D 3220439040
> =09ua =3D 0x2aaaaacc0000

Together, it's the first 3 GB of memory.

I understand now what you mean.  Yeah, the format should be changed
to include the offset (why does vhost-user need the ua at all?
perhaps the offset can replace the ua).

> BTW Any idea what to do with region 2, it doesn=E2=80=99t look like the o=
ne belonging
> to the same place, but qemu_get_ram_fd() returns same FD for it.

This must be a bug.  I would have expected qemu_get_ram_fd to return -1
here, so no descriptor should be passed to vhost-user.

Paolo