From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KeX6l-0007vc-AR for qemu-devel@nongnu.org; Sat, 13 Sep 2008 11:32:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KeX6j-0007ul-T0 for qemu-devel@nongnu.org; Sat, 13 Sep 2008 11:32:23 -0400 Received: from [199.232.76.173] (port=38699 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KeX6j-0007ui-Nr for qemu-devel@nongnu.org; Sat, 13 Sep 2008 11:32:21 -0400 Received: from ecfrec.frec.bull.fr ([129.183.4.8]:38132) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KeX6j-0008Nr-CK for qemu-devel@nongnu.org; Sat, 13 Sep 2008 11:32:21 -0400 From: Laurent Vivier In-Reply-To: <48CB11EE.7040808@codemonkey.ws> References: <48CB11EE.7040808@codemonkey.ws> Content-Type: text/plain; charset=utf-8 Date: Sat, 13 Sep 2008 17:30:15 +0200 Message-Id: <1221319815.4170.14.camel@frecb07144> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [PATCH][RFC][RFT] Let qemu-nbd build on Windows and replace QEMU_IMG/QEMU_NBD with QEMU_TOOL Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: "qemu-devel@nongnu.org" Le vendredi 12 septembre 2008 =C3=A0 20:05 -0500, Anthony Liguori a =C3=A9= crit : > This patch attempts to clean up the mess with qemu-nbd in the Makefile=20 > in order to get it building and working on Windows. I checked=20 > block-nbd, qemu-img, and qemu-nbd on Windows and Linux and everything=20 > seems to work. However, there were some defined(QEMU_IMG) that didn't=20 > include defined(QEMU_NBD) that now are covered by QEMU_TOOL so I'd like= =20 > Laurent to look them over and see if they were intentional. If I remember correctly they were intentional: - some of them because qemu-nbd didn't support windows (but you have corrected this) - others because qemu-img doesn't need to open file with O_DIRECT whereas qemu-nbd must (--nocache option) (and I think you break this) Did you test "qemu-nbd --nocache" ? > Basically, there are no longer qemu-nbd-*.o objects. qemu-img-*.o have= =20 > -DQEMU_TOOL defined and qemu-img/qemu-nbd use identical copies of those= =20 > objects. A special object is no longer build for nbd.c either. >=20 > My longer goal would be to eliminate as many qemu-img-* objects as=20 > possible but let's take that one step at a time. I think it's a good idea... Regards, Laurent --=20 ----------------- Laurent.Vivier@bull.net ------------------ "La perfection est atteinte non quand il ne reste rien =C3=A0 ajouter mais quand il ne reste rien =C3=A0 enlever." Saint Exup=C3=A9ry