* [PATCH] target/rx: set PSW.I when executing wait instruction
@ 2022-04-17 4:59 Tomoaki Kawada
2022-04-17 16:02 ` Richard Henderson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tomoaki Kawada @ 2022-04-17 4:59 UTC (permalink / raw)
To: qemu-devel; +Cc: Tomoaki Kawada, Yoshinori Sato
This patch fixes the implementation of the wait instruction to
implicitly update PSW.I as required by the ISA specification.
Signed-off-by: Tomoaki Kawada <i@yvt.jp>
---
target/rx/op_helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c
index 11f952d340..81645adde3 100644
--- a/target/rx/op_helper.c
+++ b/target/rx/op_helper.c
@@ -448,6 +448,7 @@ void QEMU_NORETURN helper_wait(CPURXState *env)
cs->halted = 1;
env->in_sleep = 1;
+ env->psw_i = 1;
raise_exception(env, EXCP_HLT, 0);
}
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] target/rx: set PSW.I when executing wait instruction
2022-04-17 4:59 [PATCH] target/rx: set PSW.I when executing wait instruction Tomoaki Kawada
@ 2022-04-17 16:02 ` Richard Henderson
2022-04-18 13:17 ` Yoshinori Sato
2022-04-21 17:08 ` Richard Henderson
2 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2022-04-17 16:02 UTC (permalink / raw)
To: Tomoaki Kawada, qemu-devel; +Cc: Yoshinori Sato
On 4/16/22 21:59, Tomoaki Kawada wrote:
> This patch fixes the implementation of the wait instruction to
> implicitly update PSW.I as required by the ISA specification.
>
> Signed-off-by: Tomoaki Kawada <i@yvt.jp>
> ---
> target/rx/op_helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c
> index 11f952d340..81645adde3 100644
> --- a/target/rx/op_helper.c
> +++ b/target/rx/op_helper.c
> @@ -448,6 +448,7 @@ void QEMU_NORETURN helper_wait(CPURXState *env)
>
> cs->halted = 1;
> env->in_sleep = 1;
> + env->psw_i = 1;
> raise_exception(env, EXCP_HLT, 0);
> }
>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] target/rx: set PSW.I when executing wait instruction
2022-04-17 4:59 [PATCH] target/rx: set PSW.I when executing wait instruction Tomoaki Kawada
2022-04-17 16:02 ` Richard Henderson
@ 2022-04-18 13:17 ` Yoshinori Sato
2022-04-21 17:08 ` Richard Henderson
2 siblings, 0 replies; 4+ messages in thread
From: Yoshinori Sato @ 2022-04-18 13:17 UTC (permalink / raw)
To: Tomoaki Kawada; +Cc: qemu-devel
On Sun, 17 Apr 2022 13:59:38 +0900,
Tomoaki Kawada wrote:
>
> This patch fixes the implementation of the wait instruction to
> implicitly update PSW.I as required by the ISA specification.
>
> Signed-off-by: Tomoaki Kawada <i@yvt.jp>
> ---
> target/rx/op_helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c
> index 11f952d340..81645adde3 100644
> --- a/target/rx/op_helper.c
> +++ b/target/rx/op_helper.c
> @@ -448,6 +448,7 @@ void QEMU_NORETURN helper_wait(CPURXState *env)
>
> cs->halted = 1;
> env->in_sleep = 1;
> + env->psw_i = 1;
> raise_exception(env, EXCP_HLT, 0);
> }
>
> --
> 2.35.1
>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
--
Yosinori Sato
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] target/rx: set PSW.I when executing wait instruction
2022-04-17 4:59 [PATCH] target/rx: set PSW.I when executing wait instruction Tomoaki Kawada
2022-04-17 16:02 ` Richard Henderson
2022-04-18 13:17 ` Yoshinori Sato
@ 2022-04-21 17:08 ` Richard Henderson
2 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2022-04-21 17:08 UTC (permalink / raw)
To: Tomoaki Kawada, qemu-devel; +Cc: Yoshinori Sato
On 4/16/22 21:59, Tomoaki Kawada wrote:
> This patch fixes the implementation of the wait instruction to
> implicitly update PSW.I as required by the ISA specification.
>
> Signed-off-by: Tomoaki Kawada <i@yvt.jp>
> ---
> target/rx/op_helper.c | 1 +
> 1 file changed, 1 insertion(+)
Queued to target-rx-next.
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-21 18:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-17 4:59 [PATCH] target/rx: set PSW.I when executing wait instruction Tomoaki Kawada
2022-04-17 16:02 ` Richard Henderson
2022-04-18 13:17 ` Yoshinori Sato
2022-04-21 17:08 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).