qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Lauro Ramos Venancio <lauro.venancio@openbossa.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] page_check_range: fix wrap around test
Date: Wed, 15 Oct 2008 18:36:11 -0300	[thread overview]
Message-ID: <1224106571.7266.9.camel@laurov-desktop> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 199 bytes --]

Move up the warp around test because line 
'end = TARGET_PAGE_ALIGN(start+len);'
can interfere on it causing Segmentation Fault.

-- 
Lauro Ramos Venancio
INdT - Instituto Nokia de Tecnologia

[-- Attachment #1.2: fix_page_check_range.patch --]
[-- Type: text/x-patch, Size: 662 bytes --]

Index: exec.c
===================================================================
--- exec.c	(revision 5391)
+++ exec.c	(working copy)
@@ -2068,12 +2068,13 @@
     target_ulong end;
     target_ulong addr;
 
+    if( start + len < start )
+        /* we've wrapped around */
+        return -1;
+
     end = TARGET_PAGE_ALIGN(start+len); /* must do before we loose bits in the next step */
     start = start & TARGET_PAGE_MASK;
 
-    if( end < start )
-        /* we've wrapped around */
-        return -1;
     for(addr = start; addr < end; addr += TARGET_PAGE_SIZE) {
         p = page_find(addr >> TARGET_PAGE_BITS);
         if( !p )

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

             reply	other threads:[~2008-10-15 21:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-15 21:36 Lauro Ramos Venancio [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-10-15 22:57 [Qemu-devel] [PATCH] page_check_range: fix wrap around test Lauro Ramos Venancio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224106571.7266.9.camel@laurov-desktop \
    --to=lauro.venancio@openbossa.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).