From: Glauber Costa <glommer@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, jan.kiszka@siemens.com, jes@sgi.com,
avi@qumranet.com, Glauber Costa <gcosta@redhat.com>,
dmitry.baryshkov@siemens.com
Subject: [Qemu-devel] [PATCH 11/21] remove kqemu reference from hw/pc.c
Date: Wed, 15 Oct 2008 19:55:08 -0200 [thread overview]
Message-ID: <1224107718-19128-12-git-send-email-glommer@redhat.com> (raw)
In-Reply-To: <1224107718-19128-1-git-send-email-glommer@redhat.com>
From: Glauber Costa <gcosta@redhat.com>
Instead, route cpu_get_ticks through accel driver.
Signed-off-by: Glauber Costa <glommer@redhat.com>
---
accel.c | 3 +++
accel.h | 12 ++++++++++++
hw/pc.c | 13 ++-----------
kqemu.c | 6 ++++++
4 files changed, 23 insertions(+), 11 deletions(-)
diff --git a/accel.c b/accel.c
index 4cdfaf5..45ad1ee 100644
--- a/accel.c
+++ b/accel.c
@@ -25,5 +25,8 @@ QEMUAccel noaccel = {
.profile = accel_nop,
.set_notdirty = accel_nop,
.modify_page = accel_nop,
+#ifndef CONFIG_USER_ONLY
+ .get_real_ticks = cpu_get_ticks,
+#endif
};
diff --git a/accel.h b/accel.h
index 1f0d41b..c305e8c 100644
--- a/accel.h
+++ b/accel.h
@@ -10,6 +10,9 @@ typedef struct QEMUAccel {
int (*profile)(CPUState *env, char *buf);
void (*set_notdirty)(ram_addr_t addr);
void (*modify_page)(ram_addr_t addr, int dirty_flags);
+#ifndef CONFIG_USER_ONLY
+ uint64_t (*get_real_ticks)(void);
+#endif
} QEMUAccel;
extern QEMUAccel *current_accel;
@@ -60,4 +63,13 @@ static inline void accel_modify_page(target_ulong addr, int dirty_flags)
current_accel->modify_page(addr, dirty_flags);
}
+int64_t cpu_get_ticks(void);
+
+#ifndef CONFIG_USER_ONLY
+static inline uint64_t accel_get_real_ticks(void)
+{
+ return current_accel->get_real_ticks();
+}
+#endif
+
#endif
diff --git a/hw/pc.c b/hw/pc.c
index 34683e7..2f56c1f 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -33,6 +33,7 @@
#include "boards.h"
#include "console.h"
#include "fw_cfg.h"
+#include "accel.h"
/* output Bochs bios info messages */
//#define DEBUG_BIOS
@@ -75,17 +76,7 @@ static void ioportF0_write(void *opaque, uint32_t addr, uint32_t data)
/* TSC handling */
uint64_t cpu_get_tsc(CPUX86State *env)
{
- /* Note: when using kqemu, it is more logical to return the host TSC
- because kqemu does not trap the RDTSC instruction for
- performance reasons */
-#ifdef USE_KQEMU
- if (env->kqemu_enabled) {
- return cpu_get_real_ticks();
- } else
-#endif
- {
- return cpu_get_ticks();
- }
+ return accel_get_real_ticks();
}
/* SMM support */
diff --git a/kqemu.c b/kqemu.c
index 9c3d0c5..e1c2dc3 100644
--- a/kqemu.c
+++ b/kqemu.c
@@ -444,6 +444,12 @@ QEMUAccel kqemu_accel = {
.profile = kqemu_profile,
.set_notdirty = kqemu_set_notdirty,
.modify_page = kqemu_modify_page,
+#ifndef CONFIG_USER_ONLY
+ /* Note: when using kqemu, it is more logical to return the host TSC
+ because kqemu does not trap the RDTSC instruction for
+ performance reasons */
+ .get_real_ticks = cpu_get_real_ticks,
+#endif
};
--
1.5.5.1
next prev parent reply other threads:[~2008-10-15 19:59 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 21:54 [Qemu-devel] [PATCH 0/21] Accelerators: cleaned up version Glauber Costa
2008-10-15 20:16 ` [Qemu-devel] " Anthony Liguori
2008-10-15 21:54 ` [Qemu-devel] [PATCH 01/21] split kqemu_init into two Glauber Costa
2008-10-15 21:54 ` [Qemu-devel] [PATCH 02/21] introduce QEMUAccel and fill it with interrupt specific driver Glauber Costa
2008-10-15 20:20 ` [Qemu-devel] " Anthony Liguori
2008-10-15 20:58 ` Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 03/21] init env made accel driver Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 04/21] wrap cache flushing functions into accel drivers Glauber Costa
2008-10-15 20:23 ` [Qemu-devel] " Anthony Liguori
2008-10-15 21:02 ` Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 05/21] turn info kqemu into generic info accelerator Glauber Costa
2008-10-15 20:25 ` [Qemu-devel] " Anthony Liguori
2008-10-15 21:23 ` M. Warner Losh
2008-10-15 21:28 ` Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 06/21] separate accelerator part of info profiler Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 07/21] move kqemu externs to kqemu.h Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 08/21] move disabling code to kqemu.c instead of vl.c Glauber Costa
2008-10-15 20:32 ` [Qemu-devel] " Anthony Liguori
2008-10-15 21:02 ` Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 09/21] set_notdirty goes through accel wrapper Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 10/21] wrap modify_page through accel calls Glauber Costa
2008-10-15 21:55 ` Glauber Costa [this message]
2008-10-15 21:55 ` [Qemu-devel] [PATCH 12/21] build list of available accelerators Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 13/21] provide --accel option Glauber Costa
2008-10-15 20:36 ` [Qemu-devel] " Anthony Liguori
2008-10-15 21:08 ` Glauber Costa
2008-10-16 19:49 ` Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 14/21] add tsc field to cpu definition Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 15/21] shift for masks Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 16/21] add hook to cpu_register_physical_memory Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 17/21] accel_trace_io Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 18/21] get_env accel wrapper Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 19/21] add next_cpu_index Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 20/21] check wether kqemu is enabled in open code Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 21/21] provide an opaque for accelerator in cpu state Glauber Costa
2008-10-16 9:26 ` [Qemu-devel] " Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224107718-19128-12-git-send-email-glommer@redhat.com \
--to=glommer@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@qumranet.com \
--cc=dmitry.baryshkov@siemens.com \
--cc=gcosta@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=jes@sgi.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).