From: Glauber Costa <glommer@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, jan.kiszka@siemens.com, jes@sgi.com,
avi@qumranet.com, Glauber Costa <gcosta@redhat.com>,
dmitry.baryshkov@siemens.com
Subject: [Qemu-devel] [PATCH 18/21] get_env accel wrapper
Date: Wed, 15 Oct 2008 19:55:15 -0200 [thread overview]
Message-ID: <1224107718-19128-19-git-send-email-glommer@redhat.com> (raw)
In-Reply-To: <1224107718-19128-1-git-send-email-glommer@redhat.com>
From: Glauber Costa <gcosta@redhat.com>
Allow the current accelerator to provide it's own, customized
address of the CPUState structure used for the env variable.
Signed-off-by: Glauber Costa <gcosta@redhat.com>
---
accel.c | 6 ++++++
accel.h | 7 +++++++
kqemu.c | 1 +
target-i386/helper.c | 2 +-
4 files changed, 15 insertions(+), 1 deletions(-)
diff --git a/accel.c b/accel.c
index 6517af2..08329a4 100644
--- a/accel.c
+++ b/accel.c
@@ -14,6 +14,11 @@ int noaccel_info(CPUState *env, char *buf)
return sprintf(buf, "no accelerator present.\n");
}
+CPUState *noaccel_get_env(void)
+{
+ return qemu_mallocz(sizeof(CPUState));
+}
+
#define accel_nop ((void *)_accel_nop)
/* Accelerator wrapper for the no-accel (raw qemu) case */
@@ -21,6 +26,7 @@ QEMUAccel noaccel = {
.name = "none",
.cpu_interrupt = accel_nop,
.init_env = accel_nop,
+ .get_env = noaccel_get_env,
.start = accel_nop,
.flush_cache = accel_nop,
.flush_page = accel_nop,
diff --git a/accel.h b/accel.h
index 5f04163..1d5986a 100644
--- a/accel.h
+++ b/accel.h
@@ -4,6 +4,7 @@
typedef struct QEMUAccel {
char *name;
void (*cpu_interrupt)(CPUState *env);
+ CPUState *(*get_env)(void);
void (*init_env)(CPUState *env);
int (*start)(void);
void (*flush_cache)(CPUState *env, int global);
@@ -35,6 +36,7 @@ extern QEMUAccel kqemu_accel;
extern QEMUCont *head;
void *qemu_mallocz(size_t size);
+extern CPUState *noaccel_get_env(void);
static inline int register_qemu_accel(QEMUAccel *accel)
{
@@ -91,6 +93,11 @@ static inline int accel_start(void)
return status;
}
+static inline CPUState *accel_get_env(void)
+{
+ return current_accel->get_env();
+}
+
static inline void accel_init_env(CPUState *env)
{
current_accel->init_env(env);
diff --git a/kqemu.c b/kqemu.c
index 58e9e3f..d543e29 100644
--- a/kqemu.c
+++ b/kqemu.c
@@ -453,6 +453,7 @@ QEMUAccel kqemu_accel = {
.name = "KQEMU",
.cpu_interrupt = kqemu_cpu_interrupt,
.init_env = kqemu_init_env,
+ .get_env = noaccel_get_env,
.start = kqemu_start,
.flush_cache = kqemu_flush,
.flush_page = kqemu_flush_page,
diff --git a/target-i386/helper.c b/target-i386/helper.c
index d15e3f9..8fc33c6 100644
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -98,7 +98,7 @@ CPUX86State *cpu_x86_init(const char *cpu_model)
CPUX86State *env;
static int inited;
- env = qemu_mallocz(sizeof(CPUX86State));
+ env = accel_get_env();
if (!env)
return NULL;
cpu_exec_init(env);
--
1.5.5.1
next prev parent reply other threads:[~2008-10-15 19:59 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 21:54 [Qemu-devel] [PATCH 0/21] Accelerators: cleaned up version Glauber Costa
2008-10-15 20:16 ` [Qemu-devel] " Anthony Liguori
2008-10-15 21:54 ` [Qemu-devel] [PATCH 01/21] split kqemu_init into two Glauber Costa
2008-10-15 21:54 ` [Qemu-devel] [PATCH 02/21] introduce QEMUAccel and fill it with interrupt specific driver Glauber Costa
2008-10-15 20:20 ` [Qemu-devel] " Anthony Liguori
2008-10-15 20:58 ` Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 03/21] init env made accel driver Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 04/21] wrap cache flushing functions into accel drivers Glauber Costa
2008-10-15 20:23 ` [Qemu-devel] " Anthony Liguori
2008-10-15 21:02 ` Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 05/21] turn info kqemu into generic info accelerator Glauber Costa
2008-10-15 20:25 ` [Qemu-devel] " Anthony Liguori
2008-10-15 21:23 ` M. Warner Losh
2008-10-15 21:28 ` Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 06/21] separate accelerator part of info profiler Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 07/21] move kqemu externs to kqemu.h Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 08/21] move disabling code to kqemu.c instead of vl.c Glauber Costa
2008-10-15 20:32 ` [Qemu-devel] " Anthony Liguori
2008-10-15 21:02 ` Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 09/21] set_notdirty goes through accel wrapper Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 10/21] wrap modify_page through accel calls Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 11/21] remove kqemu reference from hw/pc.c Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 12/21] build list of available accelerators Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 13/21] provide --accel option Glauber Costa
2008-10-15 20:36 ` [Qemu-devel] " Anthony Liguori
2008-10-15 21:08 ` Glauber Costa
2008-10-16 19:49 ` Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 14/21] add tsc field to cpu definition Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 15/21] shift for masks Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 16/21] add hook to cpu_register_physical_memory Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 17/21] accel_trace_io Glauber Costa
2008-10-15 21:55 ` Glauber Costa [this message]
2008-10-15 21:55 ` [Qemu-devel] [PATCH 19/21] add next_cpu_index Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 20/21] check wether kqemu is enabled in open code Glauber Costa
2008-10-15 21:55 ` [Qemu-devel] [PATCH 21/21] provide an opaque for accelerator in cpu state Glauber Costa
2008-10-16 9:26 ` [Qemu-devel] " Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224107718-19128-19-git-send-email-glommer@redhat.com \
--to=glommer@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@qumranet.com \
--cc=dmitry.baryshkov@siemens.com \
--cc=gcosta@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=jes@sgi.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).