From: Lauro Ramos Venancio <lauro.venancio@openbossa.org>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] implement CLONE_CHILD_CLEARTID
Date: Thu, 16 Oct 2008 11:28:25 -0300 [thread overview]
Message-ID: <1224167305.7266.54.camel@laurov-desktop> (raw)
In-Reply-To: <200810161419.39245.paul@codesourcery.com>
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
On Thu, 2008-10-16 at 14:19 +0100, Paul Brook wrote:
> Using the host set_tid_address is wrong. This is liable to break the host
> libc/libpthread. The current set_tid_address implementation is similarly
> broken.
I know that the clone implementation is far from the perfection and it
is very hard to implement all the clone flags using a high level API
(pthread).
This patch doesn't break seriously the host libc/libpthread. Pthread
uses the tid_address only for pthread_join. So, actually, this patch
breaks the host pthread_join (and pthread_timedjoin_np), but it makes
the emulated pthread_join work. As the qemu doesn't use pthread_join, I
think it worth to apply this patch.
--
Lauro Ramos Venancio
INdT - Instituto Nokia de Tecnologia
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2008-10-16 14:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 22:57 [Qemu-devel] [PATCH] implement CLONE_CHILD_CLEARTID Lauro Ramos Venancio
2008-10-16 13:19 ` Paul Brook
2008-10-16 14:28 ` Lauro Ramos Venancio [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-02-02 9:19 Riku Voipio
2008-10-15 22:18 Lauro Ramos Venancio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224167305.7266.54.camel@laurov-desktop \
--to=lauro.venancio@openbossa.org \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).