From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KqTq4-0007C6-1n
	for qemu-devel@nongnu.org; Thu, 16 Oct 2008 10:28:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KqTq2-0007Bp-3z
	for qemu-devel@nongnu.org; Thu, 16 Oct 2008 10:28:31 -0400
Received: from [199.232.76.173] (port=57446 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KqTq1-0007Bm-V5
	for qemu-devel@nongnu.org; Thu, 16 Oct 2008 10:28:29 -0400
Received: from wx-out-0506.google.com ([66.249.82.234]:31170)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lauro.venancio@openbossa.org>) id 1KqTq1-0003XK-92
	for qemu-devel@nongnu.org; Thu, 16 Oct 2008 10:28:29 -0400
Received: by wx-out-0506.google.com with SMTP id h27so10748wxd.4
	for <qemu-devel@nongnu.org>; Thu, 16 Oct 2008 07:28:27 -0700 (PDT)
Subject: Re: [Qemu-devel] [PATCH] implement CLONE_CHILD_CLEARTID
From: Lauro Ramos Venancio <lauro.venancio@openbossa.org>
In-Reply-To: <200810161419.39245.paul@codesourcery.com>
References: <1224111451.7266.39.camel@laurov-desktop>
	<200810161419.39245.paul@codesourcery.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-vItaXFMvPVR6YcUUN42Q"
Date: Thu, 16 Oct 2008 11:28:25 -0300
Message-Id: <1224167305.7266.54.camel@laurov-desktop>
Mime-Version: 1.0
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org


--=-vItaXFMvPVR6YcUUN42Q
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Thu, 2008-10-16 at 14:19 +0100, Paul Brook wrote:

> Using the host set_tid_address is wrong. This is liable to break the host=
=20
> libc/libpthread.  The current set_tid_address implementation is similarly=
=20
> broken.

I know that the clone implementation is far from the perfection and it
is very hard to implement all the clone flags using a high level API
(pthread).=20

This patch doesn't break seriously the host libc/libpthread. Pthread
uses the tid_address only for pthread_join. So, actually, this patch
breaks the host pthread_join (and pthread_timedjoin_np), but it makes
the emulated pthread_join work. As the qemu doesn't use pthread_join, I
think it worth to apply this patch.
=20
--=20
Lauro Ramos Venancio
INdT - Instituto Nokia de Tecnologia

--=-vItaXFMvPVR6YcUUN42Q
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBI90+JH6xNdhO2vuERArhhAJ4rXfPyyO2YsRudiCVFgenYOBRKfQCfbvAc
iioU7YdontpS3yMf6G+/lIQ=
=0cyU
-----END PGP SIGNATURE-----

--=-vItaXFMvPVR6YcUUN42Q--