From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kzgyz-0002DD-32 for qemu-devel@nongnu.org; Mon, 10 Nov 2008 19:19:49 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kzgyy-0002CZ-Cq for qemu-devel@nongnu.org; Mon, 10 Nov 2008 19:19:48 -0500 Received: from [199.232.76.173] (port=41144 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kzgyx-0002CO-Sg for qemu-devel@nongnu.org; Mon, 10 Nov 2008 19:19:47 -0500 Received: from mx2.redhat.com ([66.187.237.31]:39756) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kzgyx-00087M-HR for qemu-devel@nongnu.org; Mon, 10 Nov 2008 19:19:47 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mAB0Jjio029301 for ; Mon, 10 Nov 2008 19:19:46 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mAB0JiAL031703 for ; Mon, 10 Nov 2008 19:19:45 -0500 Received: from localhost.localdomain (vpn-12-7.rdu.redhat.com [10.11.12.7]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id mAB0JgUw023994 for ; Mon, 10 Nov 2008 19:19:44 -0500 From: Glauber Costa Date: Tue, 11 Nov 2008 00:16:05 -0200 Message-Id: <1226369769-5109-2-git-send-email-glommer@redhat.com> In-Reply-To: <1226369769-5109-1-git-send-email-glommer@redhat.com> References: <1226369769-5109-1-git-send-email-glommer@redhat.com> Subject: [Qemu-devel] [PATCH 1/5] better type checking for vga Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org unsigned long is too bad of a type. Use ram_addr_t instead. Signed-off-by: Glauber Costa --- hw/cirrus_vga.c | 4 ++-- hw/vga.c | 2 +- hw/vga_int.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index 55f3ced..c23b6a1 100644 --- a/hw/cirrus_vga.c +++ b/hw/cirrus_vga.c @@ -3232,7 +3232,7 @@ static void cirrus_init_common(CirrusVGAState * s, int device_id, int is_pci) ***************************************/ void isa_cirrus_vga_init(DisplayState *ds, uint8_t *vga_ram_base, - unsigned long vga_ram_offset, int vga_ram_size) + ram_addr_t vga_ram_offset, int vga_ram_size) { CirrusVGAState *s; @@ -3274,7 +3274,7 @@ static void cirrus_pci_mmio_map(PCIDevice *d, int region_num, } void pci_cirrus_vga_init(PCIBus *bus, DisplayState *ds, uint8_t *vga_ram_base, - unsigned long vga_ram_offset, int vga_ram_size) + ram_addr_t vga_ram_offset, int vga_ram_size) { PCICirrusVGAState *d; uint8_t *pci_conf; diff --git a/hw/vga.c b/hw/vga.c index 9540db0..0b38fe5 100644 --- a/hw/vga.c +++ b/hw/vga.c @@ -2105,7 +2105,7 @@ static void vga_map(PCIDevice *pci_dev, int region_num, } void vga_common_init(VGAState *s, DisplayState *ds, uint8_t *vga_ram_base, - unsigned long vga_ram_offset, int vga_ram_size) + ram_addr_t vga_ram_offset, int vga_ram_size) { int i, j, v, b; diff --git a/hw/vga_int.h b/hw/vga_int.h index 82a755e..d559fcf 100644 --- a/hw/vga_int.h +++ b/hw/vga_int.h @@ -100,7 +100,7 @@ typedef void (* vga_update_retrace_info_fn)(struct VGAState *s); #define VGA_STATE_COMMON \ uint8_t *vram_ptr; \ - unsigned long vram_offset; \ + ram_addr_t vram_offset; \ unsigned int vram_size; \ unsigned long bios_offset; \ unsigned int bios_size; \ -- 1.5.6.5