From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L10ZT-00011G-D1
	for qemu-devel@nongnu.org; Fri, 14 Nov 2008 10:26:55 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L10ZR-000114-OD
	for qemu-devel@nongnu.org; Fri, 14 Nov 2008 10:26:53 -0500
Received: from [199.232.76.173] (port=43064 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L10ZR-000111-HT
	for qemu-devel@nongnu.org; Fri, 14 Nov 2008 10:26:53 -0500
Received: from mx2.redhat.com ([66.187.237.31]:54665)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1L10ZR-0003E5-Fp
	for qemu-devel@nongnu.org; Fri, 14 Nov 2008 10:26:53 -0500
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <491C8267.9010303@codemonkey.ws>
References: <> <1226594526-1855-1-git-send-email-markmc@redhat.com>
	<1226594526-1855-2-git-send-email-markmc@redhat.com>
	<491C8267.9010303@codemonkey.ws>
Content-Type: text/plain; charset=utf-8
Date: Fri, 14 Nov 2008 15:25:43 +0000
Message-Id: <1226676343.9332.71.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH 2/3] dyngen: fix some warnings about unused
	functions
Reply-To: Mark McLoughlin <markmc@redhat.com>, qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Thu, 2008-11-13 at 13:39 -0600, Anthony Liguori wrote:
> Mark McLoughlin wrote:
> > Warnings were:
> >
> >   dyngen.c:292: error: =E2=80=98pstrcpy=E2=80=99 defined but not used
> >
> > Only used with CONFIG_FORMAT_COFF
> >
> >   dyngen.c:319: error: =E2=80=98swab32ss=E2=80=99 defined but not use=
d
> >
> > With ELF_USES_RELOCA, either swab32ss() or swab64ss() will
> > be used depending on ELF_CLASS. Easier to just mark them
> > both as unused.
> >
> >   dyngen.c:334: error: =E2=80=98get16=E2=80=99 defined but not used
> >   dyngen.c:343: error: =E2=80=98get32=E2=80=99 defined but not used
> >   dyngen.c:352: error: =E2=80=98put16=E2=80=99 defined but not used
> >   dyngen.c:359: error: =E2=80=98put32=E2=80=99 defined but not used
> >
> > Maybe be used for some host arches; easiest to mark them as
> > unused.
> >
> >   dyngen.c:425: error: =E2=80=98elf_swap_phdr=E2=80=99 defined but no=
t used
> >
> > This one is completely unused; just delete.
> >  =20
>=20
> Since dyngen is going away soon, I'm not eager to make changes to it=20
> that could possibly break on some weird architecture.  Do you think it=20
> would be terrible to just ignore this for now?

Yeah, that's fine - I was trying to make it possible to build with
--enable-werror to so it would be easier to spot new warnings.

The tcg 'TARGET_LONG_BITS is not defined' warning seems much more nasty
to solve anyway.

Well, slirp too - but you can build with --disable-slirp to get around
that.

Cheers,
Mark.