qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Mark McLoughlin <markmc@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 0/5] Add "info capabilities" monitor command
Date: Fri, 14 Nov 2008 15:51:42 +0000	[thread overview]
Message-ID: <1226677902.9332.87.camel@blaa> (raw)
In-Reply-To: <491CF04F.5020408@codemonkey.ws>

On Thu, 2008-11-13 at 21:28 -0600, Anthony Liguori wrote:

> There are really two types of features/options in QEMU.  There are 
> features/options of the emulated hardware and there are features/options 
> for how we present this hardware to the user.  The former is guest 
> visible and part of the save/restore state whereas the later is 
> transparent to the guest.
> 
> When enumerating capabilities, there really ought to be a clean split 
> between the two.  The former should just describe the variety of 
> hardware that can be presented to the guest.  This is important for 
> determining things like whether a migration target's QEMU instance is 
> compatible with the source.

I dig the distinction - but I'm not sure it's all that helpful.

e.g. the drive cache options are example of features which aren't
visible to the guest, but if you go to migrate a guest using
cache=writethrough and discover the target host doesn't support that,
then presumably you don't proceed. Which is similar to not migrating a
virtio using guest to a host without virtio support.

> With respect to limits, there are two types of limits.  There are 
> architectural limits of the emulated hardware which are intrinsic to the 
> hardware and vary for every machine.  Then there are the stupid QEMU 
> limits.  The stupid QEMU limits should always be high enough such that 
> it is greater than the architectural limits of any possible emulated 
> hardware.  If not, that is a bug and should be fixed.
> 
> So there really is no need to expose limits because they have very 
> little relationship to reality.  The stupid QEMU limits should 
> effectively be infinite.  You need to look at the machine definition to 
> determine what the real limits of the machine type are.  I don't 
> necessarily think this should be explicitly described by QEMU either.  I 
> don't mind a management tool having to be smart enough to know that an 
> IDE controller can only support 4 disks.

Fair enough, we can drop the limits stuff.

> As a general piece of advise, I think where you are starting from is a 
> bit ambitious and far too open for bike shedding to be productive.  You 
> may find it easier to start with something simpler, that has a real 
> practical utility to libvirt, and then building on that incrementally.

Certainly in favour of that. I've very little in the way of strong
opinions on this thing, except to advertise IFF_VNET_HDR :-)

Any suggestions on what the minimal starting point should be?

Cheers,
Mark.

  parent reply	other threads:[~2008-11-14 15:53 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-13 16:45 [Qemu-devel] [PATCH 0/5] Add "info capabilities" monitor command Mark McLoughlin
2008-11-13 16:45 ` [Qemu-devel] [PATCH 1/5] Re-factor nic model listing Mark McLoughlin
2008-11-13 16:46   ` [Qemu-devel] [PATCH 2/5] Add cpu_list() for any targets that don't already have it Mark McLoughlin
2008-11-13 16:46     ` [Qemu-devel] [PATCH 3/5] Rename xxx_cpu_list() to cpu_xxx_list() Mark McLoughlin
2008-11-13 16:46       ` [Qemu-devel] [PATCH 4/5] Add new cpu_names() function Mark McLoughlin
2008-11-13 16:46         ` [Qemu-devel] [PATCH 5/5] monitor: add "info capabilities" command Mark McLoughlin
2008-11-13 19:50           ` [Qemu-devel] " Anthony Liguori
2008-11-14 16:02             ` Mark McLoughlin
2008-11-14 10:07           ` [Qemu-devel] " Avi Kivity
2008-11-14 15:58             ` Mark McLoughlin
2008-11-16  7:17               ` Avi Kivity
2008-11-14 10:13           ` Daniel P. Berrange
2008-11-13 19:47         ` [Qemu-devel] Re: [PATCH 4/5] Add new cpu_names() function Anthony Liguori
2008-11-14 15:36           ` Mark McLoughlin
2008-11-13 18:35   ` [Qemu-devel] [PATCH 1/5] Re-factor nic model listing Paul Brook
2008-11-13 19:45     ` Anthony Liguori
2008-11-13 22:50       ` Paul Brook
2008-11-14  2:31         ` Jamie Lokier
2008-11-14  2:49           ` Anthony Liguori
2008-11-13 19:44   ` [Qemu-devel] " Anthony Liguori
2008-11-14 15:34     ` Mark McLoughlin
2008-11-13 17:49 ` [Qemu-devel] [PATCH 0/5] Add "info capabilities" monitor command Blue Swirl
2008-11-14  2:50   ` Jamie Lokier
2008-11-14 16:09     ` Mark McLoughlin
2008-11-14  3:28 ` [Qemu-devel] " Anthony Liguori
2008-11-14  3:51   ` Jamie Lokier
2008-11-14 15:56     ` Mark McLoughlin
2008-11-14 22:54       ` Jamie Lokier
2008-11-14 15:51   ` Mark McLoughlin [this message]
2008-11-14 22:52     ` Jamie Lokier
2008-11-14 10:16 ` [Qemu-devel] " Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1226677902.9332.87.camel@blaa \
    --to=markmc@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).