From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L2BoF-0007yT-2v
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 16:39:03 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L2BoC-0007xW-F3
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 16:39:02 -0500
Received: from [199.232.76.173] (port=42894 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L2BoB-0007xT-Uv
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 16:39:00 -0500
Received: from e4.ny.us.ibm.com ([32.97.182.144]:58173)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <hollisb@us.ibm.com>) id 1L2BoB-0002D5-Q6
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 16:38:59 -0500
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by e4.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id mAHLcZBq013075
	for <qemu-devel@nongnu.org>; Mon, 17 Nov 2008 16:38:35 -0500
Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	mAHLceSC160036
	for <qemu-devel@nongnu.org>; Mon, 17 Nov 2008 16:38:40 -0500
Received: from d01av04.pok.ibm.com (loopback [127.0.0.1])
	by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	mAHLceXD005837
	for <qemu-devel@nongnu.org>; Mon, 17 Nov 2008 16:38:40 -0500
Received: from [9.53.41.42] (slate.austin.ibm.com [9.53.41.42])
	by d01av04.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id
	mAHLcd2n005817
	for <qemu-devel@nongnu.org>; Mon, 17 Nov 2008 16:38:39 -0500
Subject: Re: [Qemu-devel] [PATCH 2/4] uImage: implement gzip support
From: Hollis Blanchard <hollisb@us.ibm.com>
In-Reply-To: <7235393795-BeMail@laptop>
References: <7235393795-BeMail@laptop>
Content-Type: text/plain; charset=utf-8
Date: Mon, 17 Nov 2008 15:38:39 -0600
Message-Id: <1226957919.3702.9.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Mon, 2008-11-17 at 22:30 +0100, Fran=C3=A7ois Revol wrote:
> > -    /* TODO: Implement compressed images.  */
> > -    if (hdr->ih_comp !=3D IH_COMP_NONE) {
> > -        fprintf(stderr, "Unable to load compressed u-boot images\
> > n");
> > +    /* TODO bzip2 support */
> > +    if (hdr->ih_comp =3D=3D IH_COMP_BZIP2) {
> > +        fprintf(stderr, "Unable to load bzip2 compressed u-boot=20
> > images\n");
>=20
> Shouldn't it still be testing for !=3DNONE && !=3DGZIP ?
> In case the header is incorrect or new compressions are added ?

I don't see what you mean about the header being incorrect, but I agree
on the second point. I'll make this change.

--=20
Hollis Blanchard
IBM Linux Technology Center