From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L2ChL-0000Iz-P1 for qemu-devel@nongnu.org; Mon, 17 Nov 2008 17:35:59 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L2ChJ-0000HM-UK for qemu-devel@nongnu.org; Mon, 17 Nov 2008 17:35:59 -0500 Received: from [199.232.76.173] (port=55900 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L2ChJ-0000H7-L7 for qemu-devel@nongnu.org; Mon, 17 Nov 2008 17:35:57 -0500 Received: from e32.co.us.ibm.com ([32.97.110.150]:44428) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L2ChJ-0007O2-FB for qemu-devel@nongnu.org; Mon, 17 Nov 2008 17:35:57 -0500 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e32.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id mAHMYgII029761 for ; Mon, 17 Nov 2008 15:34:42 -0700 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mAHMZnFk129944 for ; Mon, 17 Nov 2008 15:35:52 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mAHMZYOS001600 for ; Mon, 17 Nov 2008 15:35:34 -0700 Received: from [9.53.41.42] (slate.austin.ibm.com [9.53.41.42]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id mAHMZXuH000363 for ; Mon, 17 Nov 2008 15:35:33 -0700 Subject: Re: [Qemu-devel] [PATCH 2/4] uImage: implement gzip support From: Hollis Blanchard In-Reply-To: <20081117220709.GA20874@game.jcrosoft.org> References: <09739678475eecbf3d9de512bf1dd13d07bd6642.1226955410.git.hollisb@us.ibm.com> <9d5d305c23980946944437d1116f3f83430b40e2.1226955410.git.hollisb@us.ibm.com> <20081117220709.GA20874@game.jcrosoft.org> Content-Type: text/plain Date: Mon, 17 Nov 2008 16:35:19 -0600 Message-Id: <1226961319.3702.38.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Mon, 2008-11-17 at 23:07 +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 15:18 Mon 17 Nov , Hollis Blanchard wrote: > > /* Load a U-Boot image. */ > > int load_uboot(const char *filename, target_ulong *ep, int *is_linux) > > { > > - > > int fd; > > int size; > > uboot_image_header_t h; > > @@ -374,9 +459,9 @@ int load_uboot(const char *filename, target_ulong *ep, int *is_linux) > > goto fail; > > } > > > > - /* TODO: Implement compressed images. */ > > - if (hdr->ih_comp != IH_COMP_NONE) { > > - fprintf(stderr, "Unable to load compressed u-boot images\n"); > > + /* TODO bzip2 support */ > > + if (hdr->ih_comp == IH_COMP_BZIP2) { > > + fprintf(stderr, "Unable to load bzip2 compressed u-boot images\n"); > > goto fail; > > } > why do you remove the non compress mode? I do not. > BTW Please note 2 thinks > First this format of uImage is deprecated > we have switch to a fdt uImage format I see a new "fit" format; I assume this is what you're referring to. Who is "we"? It looks like Linux does not yet use this format, neither for PowerPC (my personal interest) nor ARM. > Secondly we aslo support now LZMA compression That's good to know, but PowerPC Linux has traditionally and continues to use gzip uImages, so that's what this patch implements. -- Hollis Blanchard IBM Linux Technology Center