From: Hollis Blanchard <hollisb@us.ibm.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] IBM PowerPC 4xx 32-bit PCI controller emulation
Date: Mon, 01 Dec 2008 13:59:29 -0600 [thread overview]
Message-ID: <1228161569.14874.55.camel@localhost.localdomain> (raw)
In-Reply-To: <f43fc5580812011015y4ce64820taa77a075db730f80@mail.gmail.com>
On Mon, 2008-12-01 at 20:15 +0200, Blue Swirl wrote:
>
> > + /* Board IRQs 2-5 are connected to UIC IRQs 28-25 */
> > + /* XXX Needs some abstracting for boards other than Bamboo. */
> > + qemu_set_irq(pic[30-irq_num], level);
> > +}
>
> The IRQs should be set up at the board level and then passed to the
> device.
As far as I can see, this isn't going to work. The functions that need
access to this information are the driver's map_irq() and set_irq(), and
neither of these callbacks is provided a pointer to the driver-specific
structure where I could store the board irqs.
Can you elaborate on your idea, or point me to existing code that
implements it?
--
Hollis Blanchard
IBM Linux Technology Center
next prev parent reply other threads:[~2008-12-01 19:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 19:22 [Qemu-devel] [PATCH] IBM PowerPC 4xx 32-bit PCI controller emulation Hollis Blanchard
2008-12-01 16:13 ` [Qemu-devel] " Hollis Blanchard
2008-12-01 18:15 ` [Qemu-devel] " Blue Swirl
2008-12-01 19:17 ` Hollis Blanchard
2008-12-01 19:59 ` Hollis Blanchard [this message]
2008-12-01 20:51 ` Blue Swirl
2008-12-02 20:02 ` [Qemu-devel] [PATCH 1/1] " Hollis Blanchard
2008-12-02 20:22 ` Anthony Liguori
2008-12-02 20:43 ` Hollis Blanchard
2008-12-02 22:13 ` Aurelien Jarno
2008-12-02 21:30 ` [Qemu-devel] [PATCH] [v3] " Hollis Blanchard
2008-12-02 22:01 ` Anthony Liguori
2008-12-02 23:53 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228161569.14874.55.camel@localhost.localdomain \
--to=hollisb@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).