From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L7Evf-0001gv-Ds for qemu-devel@nongnu.org; Mon, 01 Dec 2008 14:59:35 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L7Evc-0001gj-IW for qemu-devel@nongnu.org; Mon, 01 Dec 2008 14:59:34 -0500 Received: from [199.232.76.173] (port=58728 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L7Evc-0001gg-F9 for qemu-devel@nongnu.org; Mon, 01 Dec 2008 14:59:32 -0500 Received: from e3.ny.us.ibm.com ([32.97.182.143]:35824) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L7Evc-00006j-0p for qemu-devel@nongnu.org; Mon, 01 Dec 2008 14:59:32 -0500 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e3.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id mB1Jx3jH030577 for ; Mon, 1 Dec 2008 14:59:03 -0500 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mB1JxTpn185486 for ; Mon, 1 Dec 2008 14:59:29 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mB1Jx3E5009723 for ; Mon, 1 Dec 2008 14:59:04 -0500 Subject: Re: [Qemu-devel] [PATCH] IBM PowerPC 4xx 32-bit PCI controller emulation From: Hollis Blanchard In-Reply-To: References: <1227727332-17939-1-git-send-email-hollisb@us.ibm.com> Content-Type: text/plain Date: Mon, 01 Dec 2008 13:59:29 -0600 Message-Id: <1228161569.14874.55.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On Mon, 2008-12-01 at 20:15 +0200, Blue Swirl wrote: > > > + /* Board IRQs 2-5 are connected to UIC IRQs 28-25 */ > > + /* XXX Needs some abstracting for boards other than Bamboo. */ > > + qemu_set_irq(pic[30-irq_num], level); > > +} > > The IRQs should be set up at the board level and then passed to the > device. As far as I can see, this isn't going to work. The functions that need access to this information are the driver's map_irq() and set_irq(), and neither of these callbacks is provided a pointer to the driver-specific structure where I could store the board irqs. Can you elaborate on your idea, or point me to existing code that implements it? -- Hollis Blanchard IBM Linux Technology Center