From: Hollis Blanchard <hollisb@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Avi Kivity <avi@redhat.com>, kvm-devel <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH 2/2] Virtio block device support
Date: Mon, 01 Dec 2008 14:20:28 -0600 [thread overview]
Message-ID: <1228162828.14874.58.camel@localhost.localdomain> (raw)
In-Reply-To: <1227650239-14162-2-git-send-email-aliguori@us.ibm.com>
On Tue, 2008-11-25 at 15:57 -0600, Anthony Liguori wrote:
> diff --git a/hw/pc.h b/hw/pc.h
> index f156b9e..bbfa2d6 100644
> --- a/hw/pc.h
> +++ b/hw/pc.h
> @@ -152,4 +152,8 @@ void pci_piix4_ide_init(PCIBus *bus,
> BlockDriverState **hd_table, int devfn,
>
> void isa_ne2000_init(int base, qemu_irq irq, NICInfo *nd);
>
> +/* virtio-blk.c */
> +void *virtio_blk_init(PCIBus *bus, uint16_t vendor, uint16_t device,
> + BlockDriverState *bs);
> +
> #endif
This shouldn't be in pc.h. I don't know if you'd consider virtio.h to be
a layering violation, but the virtio layers are already being compressed
in these patches...
--
Hollis Blanchard
IBM Linux Technology Center
next prev parent reply other threads:[~2008-12-01 20:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 21:57 [Qemu-devel] [PATCH 1/2] Virtio core support Anthony Liguori
2008-11-25 21:57 ` [Qemu-devel] [PATCH 2/2] Virtio block device support Anthony Liguori
2008-11-26 18:24 ` Hollis Blanchard
2008-12-01 20:20 ` Hollis Blanchard [this message]
2008-12-01 20:22 ` Anthony Liguori
2008-11-26 18:11 ` [Qemu-devel] [PATCH 1/1] " Hollis Blanchard
2008-11-26 18:17 ` Hollis Blanchard
2008-11-26 18:22 ` [Qemu-devel] [PATCH] Remove TARGET_PAGE_SIZE from virtio interface Hollis Blanchard
2008-11-26 18:29 ` [Qemu-devel] " Hollis Blanchard
2008-12-01 18:19 ` [Qemu-devel] [PATCH] [v2] " Hollis Blanchard
2008-12-04 19:58 ` [Qemu-devel] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228162828.14874.58.camel@localhost.localdomain \
--to=hollisb@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).