From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L7FG3-0002Ki-D3 for qemu-devel@nongnu.org; Mon, 01 Dec 2008 15:20:39 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L7FG2-0002KR-N8 for qemu-devel@nongnu.org; Mon, 01 Dec 2008 15:20:39 -0500 Received: from [199.232.76.173] (port=35218 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L7FG2-0002KO-Fr for qemu-devel@nongnu.org; Mon, 01 Dec 2008 15:20:38 -0500 Received: from e5.ny.us.ibm.com ([32.97.182.145]:49848) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L7FG2-0002qh-4O for qemu-devel@nongnu.org; Mon, 01 Dec 2008 15:20:38 -0500 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e5.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id mB1KK9t6022708 for ; Mon, 1 Dec 2008 15:20:09 -0500 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mB1KKVtd136732 for ; Mon, 1 Dec 2008 15:20:31 -0500 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mB1LKeRd003985 for ; Mon, 1 Dec 2008 16:20:40 -0500 Subject: Re: [Qemu-devel] [PATCH 2/2] Virtio block device support From: Hollis Blanchard In-Reply-To: <1227650239-14162-2-git-send-email-aliguori@us.ibm.com> References: <1227650239-14162-1-git-send-email-aliguori@us.ibm.com> <1227650239-14162-2-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain Date: Mon, 01 Dec 2008 14:20:28 -0600 Message-Id: <1228162828.14874.58.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Avi Kivity , kvm-devel On Tue, 2008-11-25 at 15:57 -0600, Anthony Liguori wrote: > diff --git a/hw/pc.h b/hw/pc.h > index f156b9e..bbfa2d6 100644 > --- a/hw/pc.h > +++ b/hw/pc.h > @@ -152,4 +152,8 @@ void pci_piix4_ide_init(PCIBus *bus, > BlockDriverState **hd_table, int devfn, > > void isa_ne2000_init(int base, qemu_irq irq, NICInfo *nd); > > +/* virtio-blk.c */ > +void *virtio_blk_init(PCIBus *bus, uint16_t vendor, uint16_t device, > + BlockDriverState *bs); > + > #endif This shouldn't be in pc.h. I don't know if you'd consider virtio.h to be a layering violation, but the virtio layers are already being compressed in these patches... -- Hollis Blanchard IBM Linux Technology Center