From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBcHf-0007SI-3y for qemu-devel@nongnu.org; Mon, 06 Nov 2017 02:57:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBcHc-0003Nt-21 for qemu-devel@nongnu.org; Mon, 06 Nov 2017 02:57:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48506) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eBcHb-0003Me-Ol for qemu-devel@nongnu.org; Mon, 06 Nov 2017 02:57:23 -0500 Date: Mon, 6 Nov 2017 02:57:20 -0500 (EST) From: Pankaj Gupta Message-ID: <1228466331.27752565.1509955040884.JavaMail.zimbra@redhat.com> In-Reply-To: References: <1455443283.33337333.1500618150787.JavaMail.zimbra@redhat.com> <378b10f3-b32f-84f5-2bbc-50c2ec5bcdd4@gmail.com> <86754966-281f-c3ed-938c-f009440de563@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dan Williams Cc: Xiao Guangrong , Kevin Wolf , Jan Kara , kvm-devel , Haozhong Zhang , Stefan Hajnoczi , Ross Zwisler , Qemu Developers , Stefan Hajnoczi , "linux-nvdimm@lists.01.org" , Paolo Bonzini , ross zwisler , Nitesh Narayan Lal , Christoph Hellwig > [..] > >> Yes, the GUID will specifically identify this range as "Virtio Shared > >> Memory" (or whatever name survives after a bikeshed debate). The > >> libnvdimm core then needs to grow a new region type that mostly > >> behaves the same as a "pmem" region, but drivers/nvdimm/pmem.c grows a > >> new flush interface to perform the host communication. Device-dax > >> would be disallowed from attaching to this region type, or we could > >> grow a new device-dax type that does not allow the raw device to be > >> mapped, but allows a filesystem mounted on top to manage the flush > >> interface. > > > > > > I am afraid it is not a good idea that a single SPA is used for multiple > > purposes. For the region used as "pmem" is directly mapped to the VM so > > that guest can freely access it without host's assistance, however, for > > the region used as "host communication" is not mapped to VM, so that > > it causes VM-exit and host gets the chance to do specific operations, > > e.g, flush cache. So we'd better distinctly define these two regions to > > avoid the unnecessary complexity in hypervisor. > > Good point, I was assuming that the mmio flush interface would be > discovered separately from the NFIT-defined memory range. Perhaps via > PCI in the guest? This piece of the proposal needs a bit more > thought... Also, in earlier discussions we agreed for entire device flush whenever guest performs a fsync on DAX file. If we do a MMIO call for this, guest CPU would be trapped for the duration device flush is completed. Instead, if we do perform an asynchronous flush guest CPU's can be utilized by some other tasks till flush completes? Thanks, Pankaj