From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LA5u8-0000PX-9l for qemu-devel@nongnu.org; Tue, 09 Dec 2008 11:57:48 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LA5u6-0000P1-M3 for qemu-devel@nongnu.org; Tue, 09 Dec 2008 11:57:47 -0500 Received: from [199.232.76.173] (port=43877 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LA5u6-0000Or-F3 for qemu-devel@nongnu.org; Tue, 09 Dec 2008 11:57:46 -0500 Received: from e8.ny.us.ibm.com ([32.97.182.138]:57432) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LA5u5-0000cI-O5 for qemu-devel@nongnu.org; Tue, 09 Dec 2008 11:57:46 -0500 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by e8.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id mB9Gqwhk009313 for ; Tue, 9 Dec 2008 11:52:58 -0500 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mB9Gvgxx2457824 for ; Tue, 9 Dec 2008 11:57:42 -0500 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mB9GvgVF015388 for ; Tue, 9 Dec 2008 09:57:42 -0700 Subject: Re: [Qemu-devel] [PATCH 1/3] PPC4xx IIC and MAL From: Hollis Blanchard In-Reply-To: <187056.50657.qm@web27206.mail.ukl.yahoo.com> References: <187056.50657.qm@web27206.mail.ukl.yahoo.com> Content-Type: text/plain Date: Tue, 09 Dec 2008 10:57:41 -0600 Message-Id: <1228841861.17963.15.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: salvatorelionetti@yahoo.it Cc: qemu-devel On Tue, 2008-12-09 at 01:46 +0000, Salvatore Lionetti wrote: > Hi > > This set of patch try to full support hw present in 'walnut' board. > http://elinux.org/DHT-Walnut > > The fw used to successfully verify board is u-boot-1.3.4. > > The only component not tested is PCI: perhaps should be a good start > point for Hollis 's recent work, which i thanks for previous code > review. > > 1) IIC: new eeprom device, full emulation of 4xx master core > MAL: Moved interface so can be shared with other modules > 4xx boards: move MAL & IIC common part between ppc4xx cpu > add a list of created devices, so machine 2 phase > creation is allowed, > > Warning: to compile: > - comment line 'ppc4xx_emac_init(...)' in module hw/ppc405_boards.c > - rename ppc405ep_init(args) in ppc405xp_init("405ep", args, NULL) > > Files changed: > - Makefile.target > - Makefile > - hw/ppc405_uc.c > - hw/ppc4xx_devs.c > - hw/ppc405.h > - hw/i2c.h > - hw/iic_eeprom.c (Added) > - hw/ppc4xx.h Please split this into smaller patches which can be more easily reviewed. For example, you should send one patch that *only* moves the i2c code (and makes no changes). Then submit a patch that modifies the code in its new location. You should submit separate patches for MAL and I2C. You should not change the DEBUG #defines, nor add debug calls to printf. In other words, please remove all extraneous changes from your patch, and break it up into small self-contained pieces that can be committed one by one. -- Hollis Blanchard IBM Linux Technology Center