From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LAUC6-0006Wc-1b for qemu-devel@nongnu.org; Wed, 10 Dec 2008 13:53:58 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LAUC2-0006VD-Gj for qemu-devel@nongnu.org; Wed, 10 Dec 2008 13:53:57 -0500 Received: from [199.232.76.173] (port=53704 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LAUC2-0006VA-4q for qemu-devel@nongnu.org; Wed, 10 Dec 2008 13:53:54 -0500 Received: from e5.ny.us.ibm.com ([32.97.182.145]:45742) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LAUC1-0007tK-Iw for qemu-devel@nongnu.org; Wed, 10 Dec 2008 13:53:53 -0500 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e5.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id mBAIrAuS007269 for ; Wed, 10 Dec 2008 13:53:10 -0500 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mBAIrmAt188558 for ; Wed, 10 Dec 2008 13:53:48 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mBAIrHqE009759 for ; Wed, 10 Dec 2008 13:53:17 -0500 Subject: Re: [Qemu-devel] [PATCH 1/3] PPC4xx IIC and MAL From: Hollis Blanchard In-Reply-To: <505560.69650.qm@web27208.mail.ukl.yahoo.com> References: <505560.69650.qm@web27208.mail.ukl.yahoo.com> Content-Type: text/plain Date: Wed, 10 Dec 2008 12:53:48 -0600 Message-Id: <1228935228.9880.14.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: salvatorelionetti@yahoo.it Cc: qemu-devel On Wed, 2008-12-10 at 14:13 +0000, Salvatore Lionetti wrote: > Ok > > 1) The line code modified is 80% IIC, only few row about MAL > 2) MAL until today (if ever this patch enter in qemu) is only used to > rw registers, so no malfunction is present. > 3) As you can see many ppc* file are to modify since I2C previous > support it totally not integrated: have sense modify ppc* and never > use an IIC device? > 4) Is error prone and very tedious to extract some code, expecially if > there is no modularity advantage: one piece require the other, > 5) I already have successfully tested the expected patch. > 6) I can't do that directly so every time have 2 see if main line is > updated or not, merge svn file with current my patch status > 7) Who apply the patch only apply one click? > > In this moment i have no time to make all this retail and test. I would be very surprised if somebody applies your patch as-is, because it's messy (there are a lot of unnecessary/unrelated changes) and it's very difficult to see the functional changes. Yes, there is a natural dependency of a patch on the previous ones. This is called a "patch queue" or "patch series", and you can see other people submitting them on qemu-devel. (In fact the most recent series contains 13 patches, with #13 depending on #1-12 being committed already.) There are tools (such as quilt, guilt, and MQ) that help you manage patch series. You can use these tools to maintain your patches and update them to match the latest qemu tree. If you submit small independent patches, people will be able to easily see that they're good and commit them instantly. When you submit a large patch with lots of changes, it takes a lot more time and effort to review, and it's much less likely to be accepted. -- Hollis Blanchard IBM Linux Technology Center