From: Hollis Blanchard <hollisb@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 00/13] Cleanup some logging code
Date: Wed, 10 Dec 2008 15:37:10 -0600 [thread overview]
Message-ID: <1228945030.15931.0.camel@localhost.localdomain> (raw)
In-Reply-To: <1228933464-7670-1-git-send-email-ehabkost@redhat.com>
On Wed, 2008-12-10 at 16:24 -0200, Eduardo Habkost wrote:
> The following patches are small cleanups of the logging code on multiple
> partes of qemu. Most of them are for removing duplicated code and #ifdefs
> from the code. The patches are available on a git tree (see pull request
> below).
>
> My long-term plan is to have a propper logging API on qemu, instead of
> the global variables 'loglevel' and 'logfile'. These cleanups should
> make that work easier, in addition to the code readability improvement.
Sounds good to me. You might want to look at GRUB2's grub_dprintf(),
which has proven invaluable for low-level remote debugging. Basically
you can just tell someone to run "set debug=disk" at runtime to enable
the "disk" class of debug output. Other classes include partition map,
ELF loading, filesystems, etc. It's nothing revolutionary, but it's been
really really useful.
--
Hollis Blanchard
IBM Linux Technology Center
prev parent reply other threads:[~2008-12-10 21:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 18:24 [Qemu-devel] [PATCH 00/13] Cleanup some logging code Eduardo Habkost
2008-12-10 18:24 ` [Qemu-devel] [PATCH 01/13] hw/ppc.c: LOG_IRQ macro Eduardo Habkost
2008-12-11 21:45 ` Anthony Liguori
2008-12-11 22:54 ` Andreas Färber
2008-12-11 23:31 ` Eduardo Habkost
2008-12-14 18:09 ` Jamie Lokier
2008-12-12 14:31 ` Anthony Liguori
2008-12-10 18:24 ` [Qemu-devel] [PATCH 02/13] hw/ppc.c: use LOG_IRQ instead of #ifdefs Eduardo Habkost
2008-12-10 18:24 ` [Qemu-devel] [PATCH 03/13] hw/ppc.c: LOG_TB macro Eduardo Habkost
2008-12-10 18:24 ` [Qemu-devel] [PATCH 04/13] hw/ppc.c: use LOG_TB instead of #ifdefs Eduardo Habkost
2008-12-10 18:24 ` [Qemu-devel] [PATCH 05/13] vl.c: LOG_IOPORT macro Eduardo Habkost
2008-12-10 18:24 ` [Qemu-devel] [PATCH 06/13] vl.c: use LOG_IOPORT instead of #ifdefs Eduardo Habkost
2008-12-10 18:24 ` [Qemu-devel] [PATCH 07/13] kqemu.c: LOG_INT macro Eduardo Habkost
2008-12-10 18:24 ` [Qemu-devel] [PATCH 08/13] kqemu.c: use LOG_INT instead of #ifdefs Eduardo Habkost
2008-12-10 18:24 ` [Qemu-devel] [PATCH 09/13] kqemu.c: LOG_INT_STATE macro Eduardo Habkost
2008-12-10 18:24 ` [Qemu-devel] [PATCH 10/13] kqemu.c: use LOG_INT_STATE instead of #ifdefs Eduardo Habkost
2008-12-10 18:24 ` [Qemu-devel] [PATCH 11/13] target-i386/op_helper.c: LOG_PCALL macro Eduardo Habkost
2008-12-10 18:24 ` [Qemu-devel] [PATCH 12/13] target-i386/op_helper.c: use LOG_PCALL instead of #ifdefs Eduardo Habkost
2008-12-10 18:24 ` [Qemu-devel] [PATCH 13/13] target-cris/translate.c: create LOG_DIS macro Eduardo Habkost
2008-12-11 8:43 ` Edgar E. Iglesias
2008-12-10 21:37 ` Hollis Blanchard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228945030.15931.0.camel@localhost.localdomain \
--to=hollisb@us.ibm.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).