From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LAu5P-0005FV-Fw for qemu-devel@nongnu.org; Thu, 11 Dec 2008 17:32:47 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LAu5N-0005Ei-Uo for qemu-devel@nongnu.org; Thu, 11 Dec 2008 17:32:47 -0500 Received: from [199.232.76.173] (port=37806 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LAu5N-0005Ec-NR for qemu-devel@nongnu.org; Thu, 11 Dec 2008 17:32:45 -0500 Received: from e1.ny.us.ibm.com ([32.97.182.141]:58278) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LAu5N-0003xj-EC for qemu-devel@nongnu.org; Thu, 11 Dec 2008 17:32:45 -0500 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e1.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id mBBMW32o019339 for ; Thu, 11 Dec 2008 17:32:03 -0500 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mBBMWiT5194154 for ; Thu, 11 Dec 2008 17:32:44 -0500 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mBBMWinc008111 for ; Thu, 11 Dec 2008 17:32:44 -0500 Received: from [9.53.41.42] (slate.austin.ibm.com [9.53.41.42]) by d01av01.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id mBBMWhVs008067 for ; Thu, 11 Dec 2008 17:32:43 -0500 From: Hollis Blanchard In-Reply-To: <1229033553-26097-1-git-send-email-hollisb@us.ibm.com> References: <1229033553-26097-1-git-send-email-hollisb@us.ibm.com> Content-Type: text/plain Date: Thu, 11 Dec 2008 16:32:45 -0600 Message-Id: <1229034765.26586.34.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Thu, 2008-12-11 at 16:12 -0600, Hollis Blanchard wrote: > I'm not familiar with this device, but I'm fairly certain the writel handler is > not supposed to recurse. > > Signed-off-by: Hollis Blanchard > > diff --git a/hw/ppc405_boards.c b/hw/ppc405_boards.c > index 4144dae..1d8b6ab 100644 > --- a/hw/ppc405_boards.c > +++ b/hw/ppc405_boards.c > @@ -129,9 +129,9 @@ static uint32_t ref405ep_fpga_readl (void *opaque, target_phys_addr_t addr) > static void ref405ep_fpga_writel (void *opaque, > target_phys_addr_t addr, uint32_t value) > { > - ref405ep_fpga_writel(opaque, addr, (value >> 24) & 0xFF); > - ref405ep_fpga_writel(opaque, addr + 1, (value >> 16) & 0xFF); > - ref405ep_fpga_writel(opaque, addr + 2, (value >> 8) & 0xFF); > + ref405ep_fpga_writeb(opaque, addr, (value >> 24) & 0xFF); > + ref405ep_fpga_writeb(opaque, addr + 1, (value >> 16) & 0xFF); > + ref405ep_fpga_writeb(opaque, addr + 2, (value >> 8) & 0xFF); > ref405ep_fpga_writeb(opaque, addr + 3, value & 0xFF); > } If git weren't dumb, the subject would have read "Fix 405 FPGA emulation typo". -- Hollis Blanchard IBM Linux Technology Center