[Qemu-devel] (no subject)

[Qemu-devel] (no subject)

[Hollis Blanchard]

I'm not familiar with this device, but I'm fairly certain the writel handler is
not supposed to recurse.

Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>

diff --git a/hw/ppc405_boards.c b/hw/ppc405_boards.c
index 4144dae..1d8b6ab 100644
--- a/hw/ppc405_boards.c
+++ b/hw/ppc405_boards.c
@@ -129,9 +129,9 @@ static uint32_t ref405ep_fpga_readl (void *opaque, target_phys_addr_t addr)
 static void ref405ep_fpga_writel (void *opaque,
                                   target_phys_addr_t addr, uint32_t value)
 {
-    ref405ep_fpga_writel(opaque, addr, (value >> 24) & 0xFF);
-    ref405ep_fpga_writel(opaque, addr + 1, (value >> 16) & 0xFF);
-    ref405ep_fpga_writel(opaque, addr + 2, (value >> 8) & 0xFF);
+    ref405ep_fpga_writeb(opaque, addr, (value >> 24) & 0xFF);
+    ref405ep_fpga_writeb(opaque, addr + 1, (value >> 16) & 0xFF);
+    ref405ep_fpga_writeb(opaque, addr + 2, (value >> 8) & 0xFF);
     ref405ep_fpga_writeb(opaque, addr + 3, value & 0xFF);
 }
 

[Qemu-devel] Re:

[Hollis Blanchard]

On Thu, 2008-12-11 at 16:12 -0600, Hollis Blanchard wrote:
> I'm not familiar with this device, but I'm fairly certain the writel handler is
> not supposed to recurse.
> 
> Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
> 
> diff --git a/hw/ppc405_boards.c b/hw/ppc405_boards.c
> index 4144dae..1d8b6ab 100644
> --- a/hw/ppc405_boards.c
> +++ b/hw/ppc405_boards.c
> @@ -129,9 +129,9 @@ static uint32_t ref405ep_fpga_readl (void *opaque, target_phys_addr_t addr)
>  static void ref405ep_fpga_writel (void *opaque,
>                                    target_phys_addr_t addr, uint32_t value)
>  {
> -    ref405ep_fpga_writel(opaque, addr, (value >> 24) & 0xFF);
> -    ref405ep_fpga_writel(opaque, addr + 1, (value >> 16) & 0xFF);
> -    ref405ep_fpga_writel(opaque, addr + 2, (value >> 8) & 0xFF);
> +    ref405ep_fpga_writeb(opaque, addr, (value >> 24) & 0xFF);
> +    ref405ep_fpga_writeb(opaque, addr + 1, (value >> 16) & 0xFF);
> +    ref405ep_fpga_writeb(opaque, addr + 2, (value >> 8) & 0xFF);
>      ref405ep_fpga_writeb(opaque, addr + 3, value & 0xFF);
>  }

If git weren't dumb, the subject would have read "Fix 405 FPGA emulation
typo".

-- 
Hollis Blanchard
IBM Linux Technology Center

Re: [Qemu-devel] (no subject)

[Aurelien Jarno]

On Thu, Dec 11, 2008 at 04:12:33PM -0600, Hollis Blanchard wrote:
> I'm not familiar with this device, but I'm fairly certain the writel handler is
> not supposed to recurse.
>
> Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>

Thanks, applied.

> diff --git a/hw/ppc405_boards.c b/hw/ppc405_boards.c
> index 4144dae..1d8b6ab 100644
> --- a/hw/ppc405_boards.c
> +++ b/hw/ppc405_boards.c
> @@ -129,9 +129,9 @@ static uint32_t ref405ep_fpga_readl (void *opaque, target_phys_addr_t addr)
>  static void ref405ep_fpga_writel (void *opaque,
>                                    target_phys_addr_t addr, uint32_t value)
>  {
> -    ref405ep_fpga_writel(opaque, addr, (value >> 24) & 0xFF);
> -    ref405ep_fpga_writel(opaque, addr + 1, (value >> 16) & 0xFF);
> -    ref405ep_fpga_writel(opaque, addr + 2, (value >> 8) & 0xFF);
> +    ref405ep_fpga_writeb(opaque, addr, (value >> 24) & 0xFF);
> +    ref405ep_fpga_writeb(opaque, addr + 1, (value >> 16) & 0xFF);
> +    ref405ep_fpga_writeb(opaque, addr + 2, (value >> 8) & 0xFF);
>      ref405ep_fpga_writeb(opaque, addr + 3, value & 0xFF);
>  }
>  
> 
> 
> 

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net

[Qemu-devel] Re:

[Girish V]

Helo All,
Has anyone tried to install SMP kernel for FC5. Is there any other way
than running a 2cpu machine and installing FC5 on it (hopefully since
there are 2 cpus, smp kernel will be installed).

On that note, has anyone successfully booted a 2cpu machine? Maybe I
am doing something wrong, (as I have said in my previous post) I am
not able to get a 2cpu machine working.

Is there some other forum I should be posting this on?

Thanks,
Girish
> ------------------------------
>
> Message: 8
> Date: Mon, 19 May 2008 17:28:51 -0400
> From: "Girish V" <girish.xen@gmail.com>
> Subject: [Qemu-devel] Qemu with smp
> To: qemu-devel@nongnu.org
> Message-ID:
>        <2122f0920805191428k3a3d1858w654c4670f6f3d663@mail.gmail.com>
> Content-Type: text/plain; charset=ISO-8859-1
>
> Hi,
> I am trying to install FC5 SMP kernel on a disk image. My plan is to
> boot up a qemu smp machine and install FC5 - this way the installer
> will detect the 2 cpus and install the smp kernel.
>
> I tried to boot up a machine with 2 cpus, using "qemu -m 512M -hda
> disc.img -smp 2 -cdrom FC5-disc1.iso -no-kqemu -boot d". When I do
> this, a blank console pops up - but nothing happens beyond that. The
> console is blank and the installation doesnt seem to progress.
>
> If I try the above command without the -smp 2 option, I am able to see
> the welcome screen and installation progresses.
>
> Is there something else I need to do so that I can use the smp option.
> I am running qemu on Ubuntu Hardy Heron
>
> Thanks,
> Girish
>
>
>
>
> ------------------------------