qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>
Subject: [Qemu-devel] [RFC PATCH 0/2] Eliminate references to logfile/loglevel global vars
Date: Fri, 12 Dec 2008 19:24:18 -0200	[thread overview]
Message-ID: <1229117060-8467-1-git-send-email-ehabkost@redhat.com> (raw)

Hi,

This is actually a long 63-patch series, but for a first request for comments,
I am splitting it in two parts:

1) A set of macros are introduced for almost all usage patterns of the
   logfile/loglevel global variables.
2) 62 patches that convert almost all references to the logfile/loglevel
   global variables to use those macros (the PATCH 1/2 e-mail actually
   has pointers to the patches, either as small individual patches,
   or as a big single patch file).

These macros are _not_ a proposal for a definitive new logging API. They
are just a step for it: a way to group all usage patterns of the
logfile/loglevel variables on a single place. After all usage of those
variables is eliminated, we can more easily refactor the code to have
a proper logging API.

This series needs my previous debugging-#ifdef cleanup series to be applied
before it.

It shouldn't change any qemu behavior, but just move all references
to the logging global variables to a single place, keeping exactly the
same behaviour.

-- 
Eduardo

             reply	other threads:[~2008-12-12 21:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-12 21:24 Eduardo Habkost [this message]
2008-12-12 21:24 ` [Qemu-devel] [RFC PATCH 1/2] Create macros that will help define the logging API Eduardo Habkost
2008-12-12 21:24 ` [Qemu-devel] [RFC PATCH URL 2/2] Big conversion to the new logging macros Eduardo Habkost
2008-12-12 21:30   ` Anthony Liguori
2008-12-12 21:52     ` Blue Swirl
2008-12-12 22:27 ` [Qemu-devel] [RFC PATCH 0/2] Eliminate references to logfile/loglevel global vars Dor Laor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1229117060-8467-1-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).