From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LBfux-0005NX-E1 for qemu-devel@nongnu.org; Sat, 13 Dec 2008 20:37:11 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LBfuw-0005Mr-SK for qemu-devel@nongnu.org; Sat, 13 Dec 2008 20:37:11 -0500 Received: from [199.232.76.173] (port=54864 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LBfuw-0005MW-Em for qemu-devel@nongnu.org; Sat, 13 Dec 2008 20:37:10 -0500 Received: from e34.co.us.ibm.com ([32.97.110.152]:54289) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LBfuw-0005xD-1b for qemu-devel@nongnu.org; Sat, 13 Dec 2008 20:37:10 -0500 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e34.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id mBE1aGms008984 for ; Sat, 13 Dec 2008 18:36:16 -0700 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mBE1b68V096120 for ; Sat, 13 Dec 2008 18:37:07 -0700 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mBE1b6GB001108 for ; Sat, 13 Dec 2008 18:37:06 -0700 Subject: Re: [Qemu-devel] [PATCH 3/6] Enable KVM for ppcemb. From: Hollis Blanchard In-Reply-To: <1229036053.26586.41.camel@localhost.localdomain> References: <1229028752-9480-1-git-send-email-hollisb@us.ibm.com> <49418662.8000205@codemonkey.ws> <1229036053.26586.41.camel@localhost.localdomain> Content-Type: text/plain Date: Sat, 13 Dec 2008 19:37:02 -0600 Message-Id: <1229218622.8075.0.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kvm-ppc@vger.kernel.org On Thu, 2008-12-11 at 16:54 -0600, Hollis Blanchard wrote: > > > I don't know that kvm_ppc.c is a very information name for this sort > of > > stuff. Since this is really host specific, not target specific, why > not > > move it out of target-ppc. > > I could combine kvm_ppc.c into target-ppc/kvm.c. However, they're > really > two different things, and I thought it would cause the least confusion > if they were logically separate. Most of it is hooks required by > common > code, and then some of it isn't. (I'm thinking about e.g. IA64 doing a > copy/paste, and then wondering which functions they actually need to > implement.) Regardless, I will still need a kvm_ppc.h, so kvm_ppc.c > seemed like a good place to match. Any further thoughts on this issue? It's the only issue I still have unresolved from the initial reviews. -- Hollis Blanchard IBM Linux Technology Center