* [Qemu-devel] [PATCH] Fix DEBUG_TCGV compile error.
@ 2008-12-16 20:21 Nathan Froyd
2009-02-04 14:52 ` Laurent Desnogues
2009-02-09 20:43 ` Aurelien Jarno
0 siblings, 2 replies; 3+ messages in thread
From: Nathan Froyd @ 2008-12-16 20:21 UTC (permalink / raw)
To: qemu-devel
Don't call TCGV_LOW on arg2. This section of code falls under
#if TCG_TARGET_REG_BITS == 32, so arg2 will always be a TCGv_i32.
Signed-off-by: Nathan Froyd <froydnj@codesourcery.com>
---
tcg/tcg-op.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h
index 5432ac1..b52056c 100644
--- a/tcg/tcg-op.h
+++ b/tcg/tcg-op.h
@@ -654,7 +654,7 @@ static inline void tcg_gen_ld8s_i64(TCGv_i64 ret, TCGv_ptr arg2,
static inline void tcg_gen_ld16u_i64(TCGv_i64 ret, TCGv_ptr arg2,
tcg_target_long offset)
{
- tcg_gen_ld16u_i32(TCGV_LOW(ret), TCGV_LOW(arg2), offset);
+ tcg_gen_ld16u_i32(TCGV_LOW(ret), arg2, offset);
tcg_gen_movi_i32(TCGV_HIGH(ret), 0);
}
--
1.6.0.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] Fix DEBUG_TCGV compile error.
2008-12-16 20:21 [Qemu-devel] [PATCH] Fix DEBUG_TCGV compile error Nathan Froyd
@ 2009-02-04 14:52 ` Laurent Desnogues
2009-02-09 20:43 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Desnogues @ 2009-02-04 14:52 UTC (permalink / raw)
To: qemu-devel
Acked-by: Laurent Desnogues <laurent.desnogues@gmail.com>
On Tue, Dec 16, 2008 at 9:21 PM, Nathan Froyd <froydnj@codesourcery.com> wrote:
> Don't call TCGV_LOW on arg2. This section of code falls under
> #if TCG_TARGET_REG_BITS == 32, so arg2 will always be a TCGv_i32.
>
> Signed-off-by: Nathan Froyd <froydnj@codesourcery.com>
> ---
> tcg/tcg-op.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h
> index 5432ac1..b52056c 100644
> --- a/tcg/tcg-op.h
> +++ b/tcg/tcg-op.h
> @@ -654,7 +654,7 @@ static inline void tcg_gen_ld8s_i64(TCGv_i64 ret, TCGv_ptr arg2,
> static inline void tcg_gen_ld16u_i64(TCGv_i64 ret, TCGv_ptr arg2,
> tcg_target_long offset)
> {
> - tcg_gen_ld16u_i32(TCGV_LOW(ret), TCGV_LOW(arg2), offset);
> + tcg_gen_ld16u_i32(TCGV_LOW(ret), arg2, offset);
> tcg_gen_movi_i32(TCGV_HIGH(ret), 0);
> }
>
> --
> 1.6.0.5
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] Fix DEBUG_TCGV compile error.
2008-12-16 20:21 [Qemu-devel] [PATCH] Fix DEBUG_TCGV compile error Nathan Froyd
2009-02-04 14:52 ` Laurent Desnogues
@ 2009-02-09 20:43 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2009-02-09 20:43 UTC (permalink / raw)
To: Nathan Froyd; +Cc: qemu-devel
On Tue, Dec 16, 2008 at 12:21:45PM -0800, Nathan Froyd wrote:
> Don't call TCGV_LOW on arg2. This section of code falls under
> #if TCG_TARGET_REG_BITS == 32, so arg2 will always be a TCGv_i32.
>
> Signed-off-by: Nathan Froyd <froydnj@codesourcery.com>
> ---
> tcg/tcg-op.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied.
> diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h
> index 5432ac1..b52056c 100644
> --- a/tcg/tcg-op.h
> +++ b/tcg/tcg-op.h
> @@ -654,7 +654,7 @@ static inline void tcg_gen_ld8s_i64(TCGv_i64 ret, TCGv_ptr arg2,
> static inline void tcg_gen_ld16u_i64(TCGv_i64 ret, TCGv_ptr arg2,
> tcg_target_long offset)
> {
> - tcg_gen_ld16u_i32(TCGV_LOW(ret), TCGV_LOW(arg2), offset);
> + tcg_gen_ld16u_i32(TCGV_LOW(ret), arg2, offset);
> tcg_gen_movi_i32(TCGV_HIGH(ret), 0);
> }
>
> --
> 1.6.0.5
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-02-09 20:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-16 20:21 [Qemu-devel] [PATCH] Fix DEBUG_TCGV compile error Nathan Froyd
2009-02-04 14:52 ` Laurent Desnogues
2009-02-09 20:43 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).