qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Glauber Costa <glommer@redhat.com>
To: qemu-devel@nongnu.org
Cc: Ian.Jackson@eu.citrix.com, avi@redhat.com, kvm@vger.kernel.org,
	stefano.stabellini@eu.citrix.com
Subject: [Qemu-devel] [PATCH 2/6] re-register whole area upon lfb unmap.
Date: Thu, 18 Dec 2008 12:01:38 -0500	[thread overview]
Message-ID: <1229619702-26315-3-git-send-email-glommer@redhat.com> (raw)
In-Reply-To: <1229619702-26315-2-git-send-email-glommer@redhat.com>

set phys_offset correctly for the whole vga area when unmapping linear vram
(for vga optimization). We first register the old pieces as unassigned
memory, to make things easier for kvm (and possibly other slot based
implementations in the future). Replacing the region directly would
make the slot management significantly more complex.

Signed-off-by: Glauber Costa <glommer@redhat.com>
---
 hw/cirrus_vga.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index 83c5f40..e4f08ef 100644
--- a/hw/cirrus_vga.c
+++ b/hw/cirrus_vga.c
@@ -2657,11 +2657,8 @@ static void map_linear_vram(CirrusVGAState *s)
         s->lfb_vram_mapped = 1;
         vga_dirty_log_start((VGAState *)s);
     }
-    else {
-        cpu_register_physical_memory(isa_mem_base + 0xa0000, 0x8000, s->vga_io_memory);
-        cpu_register_physical_memory(isa_mem_base + 0xa8000, 0x8000, s->vga_io_memory);
-    }
-
+    else
+        cpu_register_physical_memory(isa_mem_base + 0xa0000, 0x20000, s->vga_io_memory);
 }
 
 static void unmap_linear_vram(CirrusVGAState *s)
-- 
1.5.6.5

  reply	other threads:[~2008-12-18 17:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-18 17:01 [Qemu-devel] [PATCH 0/6] bypass tcg memory functions -v2 Glauber Costa
2008-12-18 17:01 ` [Qemu-devel] [PATCH 1/6] remove smaller slots if registering a bigger one Glauber Costa
2008-12-18 17:01   ` Glauber Costa [this message]
2008-12-18 17:01     ` [Qemu-devel] [PATCH 3/6] isolate io handling routine Glauber Costa
2008-12-18 17:01       ` [Qemu-devel] [PATCH 4/6] replace cpu_physical_memory_rw Glauber Costa
2008-12-18 17:01         ` [Qemu-devel] [PATCH 5/6] hook cpu_register_physical_mem Glauber Costa
2008-12-18 17:01           ` [Qemu-devel] [PATCH 6/6] cache slot lookup Glauber Costa
2008-12-19 19:57           ` [Qemu-devel] [PATCH 5/6] hook cpu_register_physical_mem Blue Swirl
2008-12-19 20:14             ` Laurent Desnogues
2008-12-19 20:51             ` Anthony Liguori
2008-12-20 11:28               ` Blue Swirl
2008-12-22 17:00                 ` Glauber Costa
2008-12-23 11:43                   ` Blue Swirl
  -- strict thread matches above, loose matches on Subject: below --
2009-01-20 18:50 [Qemu-devel] [PATCH 0/6] Bypass tcg memory functions -v1.0-2009 Glauber Costa
2009-01-20 18:51 ` [Qemu-devel] [PATCH 1/6] remove smaller slots if registering a bigger one Glauber Costa
2009-01-20 18:51   ` [Qemu-devel] [PATCH 2/6] re-register whole area upon lfb unmap Glauber Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1229619702-26315-3-git-send-email-glommer@redhat.com \
    --to=glommer@redhat.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).