From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LKDP6-0006DM-8q
	for qemu-devel@nongnu.org; Tue, 06 Jan 2009 09:59:36 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LKDP3-0006DA-Rt
	for qemu-devel@nongnu.org; Tue, 06 Jan 2009 09:59:34 -0500
Received: from [199.232.76.173] (port=43463 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LKDP3-0006D7-KO
	for qemu-devel@nongnu.org; Tue, 06 Jan 2009 09:59:33 -0500
Received: from mx2.redhat.com ([66.187.237.31]:42719)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1LKDP3-0003ip-69
	for qemu-devel@nongnu.org; Tue, 06 Jan 2009 09:59:33 -0500
Subject: Re: [Qemu-devel] Re: [PATCH 1/4] Add 'set_link' monitor command
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <1229093136.4041.25.camel@blaa>
References: <> <1228820143-23580-1-git-send-email-markmc@redhat.com>
	<1228820143-23580-2-git-send-email-markmc@redhat.com>
	<493E8858.2070300@codemonkey.ws>  <1229093136.4041.25.camel@blaa>
Content-Type: text/plain
Date: Tue, 06 Jan 2009 14:59:27 +0000
Message-Id: <1231253967.23355.1.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: Mark McLoughlin <markmc@redhat.com>, qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel <qemu-devel@nongnu.org>

Hi Anthony,

On Fri, 2008-12-12 at 14:45 +0000, Mark McLoughlin wrote:
> On Tue, 2008-12-09 at 09:01 -0600, Anthony Liguori wrote:
> > > +    for(vc = vlan->first_client; vc != NULL; vc = vc->next)
> > > +        if (i++ == device_idx)
> > > +            break;
> > >   
> > 
> > I think a better way would be to allow a user to specify an id for the 
> > nic that gets saved early on.  info nics should print the id and a 
> > default id should be assigned.  I think you could argue either way as to 
> > whether the ids should be vlan local or global.
> > 
> > I sort of think that making them global has a number of advantages.  You 
> > could also use a string to identify the nics globally, it's up to you.
> 
> Okay, here's a few patches to add a vlan client name.
> 
> I'll repost the set_link patches once we agree on this part.

Re-posting a re-based version of these patches; also includes a fix for
the build error pointer out by Aurelien Jarno.

Cheers,
Mark.