From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LKcug-0005AN-81 for qemu-devel@nongnu.org; Wed, 07 Jan 2009 13:13:54 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LKcud-00058u-B6 for qemu-devel@nongnu.org; Wed, 07 Jan 2009 13:13:53 -0500 Received: from [199.232.76.173] (port=34743 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LKcud-00058p-6J for qemu-devel@nongnu.org; Wed, 07 Jan 2009 13:13:51 -0500 Received: from g1t0027.austin.hp.com ([15.216.28.34]:35652) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LKcuc-0000l2-VF for qemu-devel@nongnu.org; Wed, 07 Jan 2009 13:13:51 -0500 From: Alex Williamson In-Reply-To: <4964EFE6.2060209@codemonkey.ws> References: <1231349859.7109.82.camel@lappy> <4964EFE6.2060209@codemonkey.ws> Content-Type: text/plain Date: Wed, 07 Jan 2009 11:14:17 -0700 Message-Id: <1231352057.7109.132.camel@lappy> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 3/5][RFC] virtio-net: Name the status bits, adding promisc and allmulti Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Mark McLoughlin , qemu-devel , kvm On Wed, 2009-01-07 at 12:09 -0600, Anthony Liguori wrote: > Alex Williamson wrote: > > virtio-net: Name the status bits, adding promisc and allmulti > > > > I'd prefer the use of #define's like we have today. bit fields have > really weird packing and ordering properties across architectures. Ok, it made a few things easier, but I'll work on using a mask interface. Thanks, Alex -- Alex Williamson HP Open Source & Linux Org.