Re: [Qemu-devel] [6219] add missing MAC address to info_str for some NICs (Mark McLoughlin)

[Mark McLoughlin <markmc@redhat.com>]

On Wed, 2009-01-07 at 14:00 -0600, Anthony Liguori wrote:
> Stefan Weil wrote:
> > Anthony Liguori schrieb:
> >   
> >> Revision: 6219
> >>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6219
> >> Author:   aliguori
> >> Date:     2009-01-07 17:47:15 +0000 (Wed, 07 Jan 2009)
> >>
> >> Log Message:
> >> -----------
> >> add missing MAC address to info_str for some NICs (Mark McLoughlin)
> >>
> >> Signed-off-by: Mark McLoughlin <markmc@redhat.com>
> >> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> >>
> >> Modified Paths:
> >> --------------
> >>     trunk/hw/mcf_fec.c
> >>     trunk/hw/smc91c111.c
> >>     trunk/hw/stellaris_enet.c
> >>     trunk/hw/virtio-net.c
> >>
> >> Modified: trunk/hw/mcf_fec.c
> >> ===================================================================
> >> --- trunk/hw/mcf_fec.c	2009-01-07 17:46:21 UTC (rev 6218)
> >> +++ trunk/hw/mcf_fec.c	2009-01-07 17:47:15 UTC (rev 6219)
> >> @@ -455,4 +455,5 @@
> >>      s->vc = qemu_new_vlan_client(nd->vlan, nd->model,
> >>                                   mcf_fec_receive, mcf_fec_can_receive, s);
> >>      memcpy(s->macaddr, nd->macaddr, 6);
> >> +    qemu_format_nic_info_str(n->vc, s->macaddr);
> >>  }
> >>
> >>   
> >>     
> >
> > s->vc looks better than n->vc :-)
> >   
> 
> Good catch.

Indeed, thanks.

Strange build problems, I think:

  1) I had a build of m68k-softmmu/mcf_fec.o dated 2008-11-13 and I'm
     not sure it was being rebuilt

  2) I deleted that and "make -j4" looked like it finished just fine, 
     but if you look back up the log, the build of mcf_fec.o did indeed 
     fail

Haven't investigated any further; but clearly I need to keep a very
close watch on qemu builds :-)

Cheers,
Mark.