From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LKrSd-0003qK-6P for qemu-devel@nongnu.org; Thu, 08 Jan 2009 04:45:55 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LKrSc-0003q5-18 for qemu-devel@nongnu.org; Thu, 08 Jan 2009 04:45:54 -0500 Received: from [199.232.76.173] (port=60660 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LKrSb-0003q2-Q3 for qemu-devel@nongnu.org; Thu, 08 Jan 2009 04:45:53 -0500 Received: from mx2.redhat.com ([66.187.237.31]:41587) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LKrSb-0003ut-CK for qemu-devel@nongnu.org; Thu, 08 Jan 2009 04:45:53 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n089jqG0001997 for ; Thu, 8 Jan 2009 04:45:52 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n089jqeH028719 for ; Thu, 8 Jan 2009 04:45:52 -0500 Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n089jpuC010710 for ; Thu, 8 Jan 2009 04:45:52 -0500 Subject: Re: [Qemu-devel] [6219] add missing MAC address to info_str for some NICs (Mark McLoughlin) From: Mark McLoughlin In-Reply-To: <496509C8.6090008@codemonkey.ws> References: <4964FBE3.5070603@mail.berlios.de> <496509C8.6090008@codemonkey.ws> Content-Type: text/plain Date: Thu, 08 Jan 2009 09:45:49 +0000 Message-Id: <1231407949.4296.33.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: Mark McLoughlin , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Wed, 2009-01-07 at 14:00 -0600, Anthony Liguori wrote: > Stefan Weil wrote: > > Anthony Liguori schrieb: > > > >> Revision: 6219 > >> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6219 > >> Author: aliguori > >> Date: 2009-01-07 17:47:15 +0000 (Wed, 07 Jan 2009) > >> > >> Log Message: > >> ----------- > >> add missing MAC address to info_str for some NICs (Mark McLoughlin) > >> > >> Signed-off-by: Mark McLoughlin > >> Signed-off-by: Anthony Liguori > >> > >> Modified Paths: > >> -------------- > >> trunk/hw/mcf_fec.c > >> trunk/hw/smc91c111.c > >> trunk/hw/stellaris_enet.c > >> trunk/hw/virtio-net.c > >> > >> Modified: trunk/hw/mcf_fec.c > >> =================================================================== > >> --- trunk/hw/mcf_fec.c 2009-01-07 17:46:21 UTC (rev 6218) > >> +++ trunk/hw/mcf_fec.c 2009-01-07 17:47:15 UTC (rev 6219) > >> @@ -455,4 +455,5 @@ > >> s->vc = qemu_new_vlan_client(nd->vlan, nd->model, > >> mcf_fec_receive, mcf_fec_can_receive, s); > >> memcpy(s->macaddr, nd->macaddr, 6); > >> + qemu_format_nic_info_str(n->vc, s->macaddr); > >> } > >> > >> > >> > > > > s->vc looks better than n->vc :-) > > > > Good catch. Indeed, thanks. Strange build problems, I think: 1) I had a build of m68k-softmmu/mcf_fec.o dated 2008-11-13 and I'm not sure it was being rebuilt 2) I deleted that and "make -j4" looked like it finished just fine, but if you look back up the log, the build of mcf_fec.o did indeed fail Haven't investigated any further; but clearly I need to keep a very close watch on qemu builds :-) Cheers, Mark.