From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LN938-0003tg-JD for qemu-devel@nongnu.org; Wed, 14 Jan 2009 11:57:02 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LN935-0003oK-6k for qemu-devel@nongnu.org; Wed, 14 Jan 2009 11:57:00 -0500 Received: from [199.232.76.173] (port=56694 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LN934-0003nS-Mk for qemu-devel@nongnu.org; Wed, 14 Jan 2009 11:56:58 -0500 Received: from g4t0014.houston.hp.com ([15.201.24.17]:41749) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LN934-0004wE-9q for qemu-devel@nongnu.org; Wed, 14 Jan 2009 11:56:58 -0500 From: Alex Williamson In-Reply-To: <1231928115.4944.293.camel@localhost.localdomain> References: <1231881831.9095.192.camel@bling> <1231928115.4944.293.camel@localhost.localdomain> Content-Type: text/plain Date: Wed, 14 Jan 2009 09:57:28 -0700 Message-Id: <1231952248.7109.341.camel@lappy> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 2/5] virtio-net: Add a virtqueue for control commands from the guest Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark McLoughlin Cc: qemu-devel , kvm On Wed, 2009-01-14 at 10:15 +0000, Mark McLoughlin wrote: > On Tue, 2009-01-13 at 14:23 -0700, Alex Williamson wrote: > > + > > + ctrl = (void *)elem.out_sg[0].iov_base; > > + status = (void *)elem.in_sg[elem.in_num - 1].iov_base; > > These casts aren't needed - iov_base is a void pointer. Thanks Alex -- Alex Williamson HP Open Source & Linux Org.