From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LNt1x-0000AV-L4 for qemu-devel@nongnu.org; Fri, 16 Jan 2009 13:02:53 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LNt1v-00009l-6x for qemu-devel@nongnu.org; Fri, 16 Jan 2009 13:02:52 -0500 Received: from [199.232.76.173] (port=53409 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNt1u-00009d-Se for qemu-devel@nongnu.org; Fri, 16 Jan 2009 13:02:50 -0500 Received: from e8.ny.us.ibm.com ([32.97.182.138]:33200) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LNt1u-0006d9-Bn for qemu-devel@nongnu.org; Fri, 16 Jan 2009 13:02:50 -0500 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e8.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n0GHun4f012760 for ; Fri, 16 Jan 2009 12:56:49 -0500 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id n0GI2lII185810 for ; Fri, 16 Jan 2009 13:02:47 -0500 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n0GI2lSJ013793 for ; Fri, 16 Jan 2009 13:02:47 -0500 From: Hollis Blanchard In-Reply-To: <0A1FE637C2C7E148B9573BB60CC630E507D0DE@zch01exm26.fsl.freescale.net> References: <1232022857-2315-1-git-send-email-yu.liu@freescale.com> <1232022857-2315-2-git-send-email-yu.liu@freescale.com> <1232022857-2315-3-git-send-email-yu.liu@freescale.com> <1232022857-2315-4-git-send-email-yu.liu@freescale.com> <1232022857-2315-5-git-send-email-yu.liu@freescale.com> <1232022857-2315-6-git-send-email-yu.liu@freescale.com> <1232022857-2315-7-git-send-email-yu.liu@freescale.com> <1232022857-2315-8-git-send-email-yu.liu@freescale.com> <1232049181.6845.3.camel@slate.austin.ibm.com> <0A1FE637C2C7E148B9573BB60CC630E507D0DE@zch01exm26.fsl.freescale.net> Content-Type: text/plain Date: Fri, 16 Jan 2009 12:02:46 -0600 Message-Id: <1232128966.29223.4.camel@slate.austin.ibm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] RE: [PATCH 7/9] powerpc/kvm: Add E500 core emulation Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Yu Cc: qemu-devel@nongnu.org, kvm-ppc@vger.kernel.org On Fri, 2009-01-16 at 15:51 +0800, Liu Yu wrote: > > I still want to fixup guest memory size at certain alignment boundary, > so that KVM can handle the mmu easily. How about "ram_size &= ~(256<<20)" then? The code that you copied is more complicated because it's trying to fill in SDRAM banks which can only support a small range of fixed sizes. Since you don't have that problem, I think you should simplify. > Anyway, seems I should put them all into hw/ppce500_mpc85xx.c. Yup. -- Hollis Blanchard IBM Linux Technology Center